Replace lodash functions with ES6 equivalents in settings.js#2671
Merged
Conversation
- Replace lodash.orderBy with native JavaScript sort - Replace lodash.get with optional chaining and nullish coalescing operators Fixes #2398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces lodash functions with ES6 equivalents in the settings.js file:
lodash.orderBywith native JavaScript sortlodash.getwith optional chaining and nullish coalescing operatorsFixes #2398
Related Issues
Resolves #2398
Part of the larger effort in #2361 to replace lodash functions with vanilla JS/ES6 functions