Skip to content

#2841 - Record Merging - Merging Locations Fields Not Working#2870

Merged
corsacca merged 6 commits into
DiscipleTools:developfrom
kodinkat:2841-record-merging-merging-locations-fields-not-working
Feb 24, 2026
Merged

#2841 - Record Merging - Merging Locations Fields Not Working#2870
corsacca merged 6 commits into
DiscipleTools:developfrom
kodinkat:2841-record-merging-merging-locations-fields-not-working

Conversation

@kodinkat
Copy link
Copy Markdown
Collaborator

… field types, improve location_meta handling with JSON parsing, and ensure proper event dispatching for web components. Refactor value updates and deletions for better synchronization with UI components.
@kodinkat
Copy link
Copy Markdown
Collaborator Author

@corsacca review ready...

@corsacca
Copy link
Copy Markdown
Member

corsacca commented Feb 2, 2026

It seems like i still have the issue.

image

With locations, tags, connections, etc

…ools-theme into 2841-record-merging-merging-locations-fields-not-working
               - Updated primary field selection to ensure they are always checked as the baseline, improving clarity in the Updated column.
               - Removed previous auto-select logic for archiving fields to enforce explicit user selection.
               - Added timestamp handling for date fields to ensure accurate merging and UI updates.
               - Improved initialization timing with setTimeout to ensure all fields are properly set before triggering change events.
@kodinkat
Copy link
Copy Markdown
Collaborator Author

@corsacca see latest updates....

Screenshot 2026-02-12 at 12 36 29

@corsacca
Copy link
Copy Markdown
Member

@kodinkat
See Carthage not being merged:
image

…ools-theme into 2841-record-merging-merging-locations-fields-not-working
                - Implemented auto-selection of archiving checkboxes when a corresponding record has a value, improving user experience by ensuring relevant fields are pre-checked.
                - Added handling for location_meta fields to correctly parse and validate JSON string values, ensuring accurate data representation.
                - Removed outdated auto-select logic for archiving fields to maintain clarity in user selections.
…sistency

                - Simplified conditional checks for archiving checkbox selection to enhance clarity.
                - Reformatted code for better readability, particularly in the handling of location_meta fields and JSON parsing.
                - Ensured consistent indentation and spacing throughout the file to maintain coding standards.
@kodinkat
Copy link
Copy Markdown
Collaborator Author

@corsacca see latest updates.....

Screenshot 2026-02-23 at 11 00 32 Screenshot 2026-02-23 at 11 02 38

@corsacca
Copy link
Copy Markdown
Member

Thanks @kodinkat!

@corsacca corsacca merged commit af152a2 into DiscipleTools:develop Feb 24, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record Merging, merging locations fields not workings

2 participants