Skip to content

#2880 - Split By Not Working#2906

Open
kodinkat wants to merge 1 commit intoDiscipleTools:developfrom
kodinkat:2880-split-by-not-working
Open

#2880 - Split By Not Working#2906
kodinkat wants to merge 1 commit intoDiscipleTools:developfrom
kodinkat:2880-split-by-not-working

Conversation

@kodinkat
Copy link
Copy Markdown
Collaborator

@kodinkat kodinkat commented Apr 8, 2026

…unctionality after HTML replacement in setup_filters().
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Review

No High or Medium issues found.

The change is a minimal, correct fix. setup_filters() calls filter_accordions.html(html) (modular-list.js:645) which replaces the entire #list-filter-tabs DOM, destroying the cloned <template id="template-split-by-filter"> content and the button inside it. After that replacement, the original direct binding $('#split_by_current_filter_button').on('click', ...) is dead — the new button has no handler. Switching to $(document).on('click', '#split_by_current_filter_button', ...) delegates through the document, so the handler fires correctly after any DOM replacement.

Ready to merge.

@kodinkat
Copy link
Copy Markdown
Collaborator Author

kodinkat commented Apr 8, 2026

@corsacca review ready.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split By not working

1 participant