Skip to content

Re-layout masonry when fields are resized#2908

Open
cairocoder01 wants to merge 1 commit intoDiscipleTools:developfrom
cairocoder01:2898-masonry-reset
Open

Re-layout masonry when fields are resized#2908
cairocoder01 wants to merge 1 commit intoDiscipleTools:developfrom
cairocoder01:2898-masonry-reset

Conversation

@cairocoder01
Copy link
Copy Markdown
Collaborator

#2898

Related to DiscipleTools/disciple-tools-web-components#198 which removes the resize observer inside dt-file-upload, since this branch puts in in the theme js

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Code Review

No High severity issues found.


Summary: The change is small, correct, and well-targeted. The selector .grid .bordered-box .cell accurately matches the field-row <div class="cell"> elements nested inside each tile's .bordered-box (per single-template.php:364), and the shared resizeTimeout correctly debounces across both multiple simultaneous entries and rapid successive callbacks. The /* global ResizeObserver */ comment correctly satisfies the no-undef: 'error' ESLint rule since ResizeObserver is not in the eslint.config.mjs globals list. Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant