Skip to content

#2897 - List Exports Help Modal#2910

Open
kodinkat wants to merge 1 commit intoDiscipleTools:developfrom
kodinkat:2897-list-exports-help-modal
Open

#2897 - List Exports Help Modal#2910
kodinkat wants to merge 1 commit intoDiscipleTools:developfrom
kodinkat:2897-list-exports-help-modal

Conversation

@kodinkat
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown

Code Review

No High or Medium severity issues found.

Context: @include foundation-reveal; is commented out in dt-assets/scss/style.scss:55, meaning Foundation's built-in CSS rule that hides .reveal elements by default is not loaded. Without it, these modals are visible as raw HTML until Foundation JS initializes and hides them — which is exactly the FOUC reported in #2897 on slow connections.

Fix is correct: Adding style="display: none;" ensures the browser hides the modals immediately, before any JS runs. Foundation Reveal JS fires the open.zf.reveal event and sets display: block when a [data-open] trigger is clicked, properly overriding the inline style.

This PR is ready to merge.

@kodinkat
Copy link
Copy Markdown
Collaborator Author

@corsacca review ready....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List Exports help modal

1 participant