Commit 3040cd4
fix: resolve Clang-20 and MSVC compilation errors
column_field.hpp (Clang-20):
- Replace captureless lambda in tag_to_column_name consteval function
with a ternary expression. Clang-20 correctly rejects references to
local constexpr variables inside a [] lambda; GCC was permissive.
Ternary preserves identical min-of-two-finds logic without any capture.
test_dql_extensions.cpp (MSVC):
- Qualify ds_mysql::round and ds_mysql::format with explicit namespace
in the round/format alias test (line 297). MSVC pulls ::round from
<cmath> into the global namespace, making unqualified 'round' ambiguous
when 'using namespace ds_mysql' is also active.
ci.yml (Clang job):
- Use clang-20 instead of clang-18. clang-18 has a known bug where
__is_base_of returns false for column_field<Tag,T> derived from
column_field_tag via a base<T> partial specialization; clang-20 is
correct. Ubuntu noble 24.04 ships clang-20 in its standard repos.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent ae9cf7d commit 3040cd4
3 files changed
Lines changed: 9 additions & 14 deletions
File tree
- .github/workflows
- lib/include/ds_mysql
- tests/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
| 98 | + | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
76 | 69 | | |
77 | 70 | | |
78 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
298 | 300 | | |
299 | 301 | | |
300 | 302 | | |
| |||
0 commit comments