ci: merge into single job with MySQL service container and checkout@v6

- Merge unit-tests and integration-tests into a single 'tests' job so
  both run in the same environment (same runner, single checkout and build)
- Unit tests step gates integration tests: if it fails, subsequent steps
  are skipped automatically
- Replace manual Docker management with a GitHub Actions MySQL service
  container (fixed port 3306, TCP health check, auto-cleaned up)
- Upgrade actions/checkout@v4 -> @v6 which runs on Node.js 24, fixing
  the 'Node.js 20 actions are deprecated' warning
- Remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var (no longer needed)
- Install mysql-client alongside other deps in the single Install step
- Use explicit CTest -R filter per test suite instead of running all

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Pierre-Luc Gagné

.github/workflows/ci.yml

@@ -7,60 +7,40 @@ on:
     branches: [main]
   workflow_dispatch:
 
-env:
-  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true'
-
 jobs:
-  unit-tests:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Install dependencies
-        run: |
-          sudo apt-get update -q
-          sudo apt-get install -y software-properties-common ca-certificates gpg wget
-          # Kitware APT repo for CMake 3.31+
-          wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc \
-            | gpg --dearmor \
-            | sudo tee /usr/share/keyrings/kitware-archive-keyring.gpg > /dev/null
-          echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ noble main' \
-            | sudo tee /etc/apt/sources.list.d/kitware.list
-          sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
-          sudo apt-get update -q
-          sudo apt-get install -y cmake ninja-build g++-15 \
-            libmysqlclient-dev pkg-config
-
-      - name: Configure
-        run: cmake --preset release -DSKIP_DOCKER_MANAGEMENT=ON -DBUILD_INTEGRATION_TESTS=OFF
-        env:
-          CXX: g++-15
-          CC: gcc-15
-
-      - name: Build
-        run: cmake --build build -j$(nproc)
-
-      - name: Test
-        run: ctest --preset release
-
-  integration-tests:
-    needs: unit-tests
+  tests:
     runs-on: ubuntu-latest
 
     env:
       DS_MYSQL_TEST_HOST: 127.0.0.1
+      DS_MYSQL_TEST_PORT: 3306
       DS_MYSQL_TEST_DATABASE: ds_mysql_test
       DS_MYSQL_TEST_USER: ds_mysql_test_user
       DS_MYSQL_TEST_PASSWORD: ds_mysql_test_password
 
+    services:
+      mysql:
+        image: mysql:8.0
+        env:
+          MYSQL_ROOT_PASSWORD: root
+          MYSQL_DATABASE: ds_mysql_test
+          MYSQL_USER: ds_mysql_test_user
+          MYSQL_PASSWORD: ds_mysql_test_password
+        ports:
+          - 3306:3306
+        options: >-
+          --health-cmd="mysqladmin ping -h 127.0.0.1 --protocol=tcp"
+          --health-interval=5s
+          --health-timeout=10s
+          --health-retries=10
+
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: Install dependencies
         run: |
           sudo apt-get update -q
-          sudo apt-get install -y software-properties-common ca-certificates gpg wget
+          sudo apt-get install -y software-properties-common ca-certificates gpg wget mysql-client
           # Kitware APT repo for CMake 3.31+
           wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc \
             | gpg --dearmor \
@@ -72,74 +52,22 @@ jobs:
           sudo apt-get install -y cmake ninja-build g++-15 \
             libmysqlclient-dev pkg-config
 
-      - name: Start MySQL
-        run: |
-          CONTAINER_ID=$(docker run -d \
-            -p 0:3306 \
-            -e MYSQL_ROOT_PASSWORD=root \
-            -e MYSQL_DATABASE=ds_mysql_test \
-            -e MYSQL_USER=ds_mysql_test_user \
-            -e MYSQL_PASSWORD=ds_mysql_test_password \
-            --health-cmd="mysqladmin ping -h 127.0.0.1 --protocol=tcp" \
-            --health-interval=5s \
-            --health-timeout=10s \
-            --health-retries=10 \
-            mysql:8.0)
-          echo "MYSQL_CONTAINER_ID=$CONTAINER_ID" >> "$GITHUB_ENV"
-          PORT=$(docker inspect --format='{{(index (index .NetworkSettings.Ports "3306/tcp") 0).HostPort}}' "$CONTAINER_ID")
-          echo "DS_MYSQL_TEST_PORT=$PORT" >> "$GITHUB_ENV"
-          echo "Waiting for MySQL to be healthy..."
-          for i in $(seq 1 30); do
-            STATUS=$(docker inspect --format='{{.State.Health.Status}}' "$CONTAINER_ID")
-            if [ "$STATUS" = "healthy" ]; then
-              echo "MySQL is healthy on port $PORT"
-              break
-            fi
-            if [ "$i" = "30" ]; then
-              echo "MySQL did not become healthy in time"
-              docker logs "$CONTAINER_ID"
-              exit 1
-            fi
-            echo "Status: $STATUS, waiting... ($i/30)"
-            sleep 5
-          done
-
-      - name: Initialize database
-        run: |
-          sudo apt-get install -y mysql-client
-          echo "Waiting for TCP connection on port $DS_MYSQL_TEST_PORT..."
-          for i in $(seq 1 20); do
-            if mysql -h 127.0.0.1 -P "$DS_MYSQL_TEST_PORT" -u root -proot \
-                --connect-timeout=5 -e "SELECT 1" > /dev/null 2>&1; then
-              echo "TCP connection established"
-              break
-            fi
-            if [ "$i" = "20" ]; then
-              echo "MySQL TCP port did not become available in time"
-              exit 1
-            fi
-            echo "Waiting for TCP... ($i/20)"
-            sleep 2
-          done
-          mysql -h 127.0.0.1 -P "$DS_MYSQL_TEST_PORT" -u root -proot \
-            < tests/integration/docker/init-db.sql
-
       - name: Configure
         run: cmake --preset release -DSKIP_DOCKER_MANAGEMENT=ON
         env:
           CXX: g++-15
           CC: gcc-15
 
       - name: Build
-        run: cmake --build build -j$(nproc)
+        run: cmake --build build -j4
 
-      - name: Test
-        run: ctest --preset release
+      - name: Unit tests
+        run: ctest --preset release -R tests_unit_ds_mysql
 
-      - name: Stop MySQL
-        if: always()
+      - name: Initialize database
         run: |
-          if [ -n "$MYSQL_CONTAINER_ID" ]; then
-            docker stop "$MYSQL_CONTAINER_ID"
-            docker rm "$MYSQL_CONTAINER_ID"
-          fi
+          mysql -h 127.0.0.1 -P 3306 -u root -proot \
+            < tests/integration/docker/init-db.sql
+
+      - name: Integration tests
+        run: ctest --preset release -R tests_integration_ds_mysql