ci: add parallel Clang and MSVC validation jobs

CMake changes:
- Add MSVC compiler flags (/W4 /WX /permissive-) alongside GCC/Clang flags
- Add cross-platform MySQL detection: pkg-config on Linux/macOS,
  find_path/find_library on Windows (auto-detects MySQL Server install,
  override with -DMYSQL_ROOT_DIR=<path>)
- Consolidate lib/CMakeLists.txt: remove duplicate target_* calls and
  invalid VERSION property on INTERFACE target
- Remove spurious find_package(PkgConfig) from tests/unit/CMakeLists.txt

CI workflow:
- Rename 'tests' -> 'tests-gcc' (GCC, ubuntu, unit + integration)
- Add 'tests-clang' (Clang 15, ubuntu, unit tests only, runs in parallel)
- Add 'tests-msvc' (MSVC VS17 2022, windows-latest, unit tests only,
  runs in parallel); detects MySQL root dir from Program Files and adds
  lib dir to PATH for test runtime

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Pierre-Luc Gagné

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  tests:
+  tests-gcc:
     runs-on: ubuntu-latest
 
     env:
@@ -71,3 +71,73 @@ jobs:
 
       - name: Integration tests
         run: ctest --preset release -R tests_integration_ds_mysql
+
+  tests-clang:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update -q
+          sudo apt-get install -y software-properties-common ca-certificates gpg wget
+          # Kitware APT repo for CMake 3.31+
+          wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc \
+            | gpg --dearmor \
+            | sudo tee /usr/share/keyrings/kitware-archive-keyring.gpg > /dev/null
+          echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ noble main' \
+            | sudo tee /etc/apt/sources.list.d/kitware.list
+          sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
+          sudo apt-get update -q
+          sudo apt-get install -y cmake ninja-build clang-15 \
+            libmysqlclient-dev pkg-config
+
+      - name: Configure
+        run: cmake --preset release -DSKIP_DOCKER_MANAGEMENT=ON -DBUILD_INTEGRATION_TESTS=OFF -DBUILD_EXAMPLES=OFF
+        env:
+          CXX: clang++-15
+          CC: clang-15
+
+      - name: Build
+        run: cmake --build build -j4
+
+      - name: Unit tests
+        run: ctest --preset release -R tests_unit_ds_mysql
+
+  tests-msvc:
+    runs-on: windows-latest
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Install dependencies
+        run: |
+          choco install cmake ninja --no-progress -y
+        shell: pwsh
+
+      - name: Detect MySQL root
+        shell: pwsh
+        run: |
+          $dirs = Get-ChildItem "C:\Program Files\MySQL" -Directory -ErrorAction SilentlyContinue |
+            Where-Object { $_.Name -like "MySQL Server *" } |
+            Sort-Object Name -Descending
+          if (-not $dirs) { throw "MySQL installation not found" }
+          $root = $dirs[0].FullName
+          echo "MYSQL_ROOT_DIR=$root" >> $env:GITHUB_ENV
+          echo "$root\lib" >> $env:GITHUB_PATH
+
+      - name: Configure
+        shell: pwsh
+        run: |
+          cmake -B build `
+            -G "Visual Studio 17 2022" -A x64 `
+            -DBUILD_INTEGRATION_TESTS=OFF `
+            -DBUILD_EXAMPLES=OFF `
+            "-DMYSQL_ROOT_DIR=$env:MYSQL_ROOT_DIR"
+
+      - name: Build
+        run: cmake --build build --config Release -j4
+
+      - name: Unit tests
+        run: ctest --build-dir build -C Release -R tests_unit_ds_mysql --output-on-failure

CMakeLists.txt

@@ -41,6 +41,12 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
         -Wpedantic
         -Werror
     )
+elseif(MSVC)
+    add_compile_options(
+        /W4       # High warning level
+        /WX       # Warnings as errors
+        /permissive-  # Strict standards conformance
+    )
 endif()
 
 # Coverage flags
@@ -61,8 +67,30 @@ include(FetchContent)
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 
 # MySQL client library
-find_package(PkgConfig REQUIRED)
-pkg_check_modules(MYSQL REQUIRED mysqlclient)
+if(WIN32)
+    # On Windows, search common MySQL Server installation paths.
+    # Override by passing -DMYSQL_ROOT_DIR=<path> to cmake.
+    set(MYSQL_ROOT_DIR "" CACHE PATH "MySQL installation root (e.g. C:/Program Files/MySQL/MySQL Server 8.0)")
+    if(NOT MYSQL_ROOT_DIR)
+        file(GLOB _mysql_dirs "C:/Program Files/MySQL/MySQL Server *")
+        if(_mysql_dirs)
+            list(SORT _mysql_dirs ORDER DESCENDING)
+            list(GET _mysql_dirs 0 MYSQL_ROOT_DIR)
+            set(MYSQL_ROOT_DIR "${MYSQL_ROOT_DIR}" CACHE PATH "" FORCE)
+        else()
+            message(FATAL_ERROR "MySQL not found. Set -DMYSQL_ROOT_DIR=<path> to the MySQL installation directory.")
+        endif()
+    endif()
+
+    find_path(MYSQL_INCLUDE_DIR mysql.h PATHS "${MYSQL_ROOT_DIR}/include" NO_DEFAULT_PATH REQUIRED)
+    find_library(MYSQL_LIBRARY libmysql PATHS "${MYSQL_ROOT_DIR}/lib" NO_DEFAULT_PATH REQUIRED)
+    set(MYSQL_INCLUDE_DIRS "${MYSQL_INCLUDE_DIR}")
+    set(MYSQL_LIBRARIES "${MYSQL_LIBRARY}")
+    message(STATUS "MySQL found at: ${MYSQL_ROOT_DIR}")
+else()
+    find_package(PkgConfig REQUIRED)
+    pkg_check_modules(MYSQL REQUIRED mysqlclient)
+endif()
 
 # Note: Boost.PFR is header-only and doesn't have a standard CMake config package yet,
 # so we fetch it directly without find_package. Once Boost.PFR is officially integrated

lib/CMakeLists.txt

@@ -7,24 +7,11 @@ target_include_directories(ds_mysql
     INTERFACE
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
         $<INSTALL_INTERFACE:include>
-)
-
-target_link_libraries(ds_mysql
-    INTERFACE
-        Boost::pfr
-)
-
-target_include_directories(ds_mysql
-    INTERFACE
         ${MYSQL_INCLUDE_DIRS}
 )
 
 target_link_libraries(ds_mysql
     INTERFACE
+        Boost::pfr
         ${MYSQL_LIBRARIES}
 )
-
-# Set library properties
-set_target_properties(ds_mysql PROPERTIES
-    VERSION ${PROJECT_VERSION}
-)

tests/unit/CMakeLists.txt

@@ -14,8 +14,6 @@ if(NOT TARGET Boost::ut)
     FetchContent_MakeAvailable(boost_ut)
 endif()
 
-find_package(PkgConfig REQUIRED)
-
 add_executable(tests_unit_ds_mysql
     main.cpp
     test_ddl.cpp