This repository was archived by the owner on May 27, 2023. It is now read-only.
Added MacOS Support with new icon#39
Open
p0ryae wants to merge 2 commits into
Open
Conversation
RealDrPuc
suggested changes
Apr 7, 2023
| { | ||
| "name": "discord-tauri", | ||
| "scripts": { | ||
| "tauri": "tauri" |
Member
There was a problem hiding this comment.
Thank you for making this, I have one question tough, won't removing "tauri" from the scripts make "yarn tauri" or "npm run tauri" not work?
Contributor
Author
There was a problem hiding this comment.
I mentioned yarn serve and npm run server in my comment. Would you like me to replace serve with tauri?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discord-tauri throws an error on OSX, because of undefined main function for MacOS based operating systems (ICYMI we handle the main function per operating system). This pr aims to fix that issue. In addition, icon fitting mac aesthetic has been added. I've tested it and it functions just fine in my end.
Bonus: Added
servecli in package.json for runningcargo tauri devthrough only usingyarn serve(ornpm run serve)