Fix: Remove leading # from search result tags in advanced search (#1115)

* fix: remove leading # from search result tags in advanced search

- Strip # prefix from node badges to show correct 3-letter abbreviations
- Applies to both nodeConfig and nodeTypeLabel fallback cases
- Fixes tags showing as #CL and #QU instead of CLM and QUE

Co-authored-by: Michael Gartner <mdroidian@users.noreply.github.com>

* refactor: introduce formatBadgeText utility for consistent badge formatting

- Added formatBadgeText function to standardize the removal of leading # and limit badge text to 3 uppercase letters.
- Updated getNodeBadgeText and ResultRow components to utilize the new utility for improved consistency in badge display.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Michael Gartner <mdroidian@users.noreply.github.com>

Author: mdroidian

apps/roam/src/components/AdvancedNodeSearchDialog/AdvancedSearchDialog.tsx

@@ -1,10 +1,4 @@
-import React, {
-  useCallback,
-  useEffect,
-  useMemo,
-  useRef,
-  useState,
-} from "react";
+import React, { useCallback, useEffect, useRef, useState } from "react";
 import {
   Button,
   Dialog,
@@ -37,6 +31,7 @@ import {
   type SearchResult,
   type SortConfig,
   buildSearchIndex,
+  formatBadgeText,
   formatMetadataDate,
   searchIndexedNodes,
   sortSearchResults,
@@ -49,8 +44,9 @@ import { AdvancedSearchFooter } from "./AdvancedSearchFooter";
 
 type Props = Record<string, unknown>;
 
-const getNodeBadgeText = (node: DiscourseNode): string =>
-  (node.tag?.trim() || node.text).slice(0, 3).toUpperCase();
+const getNodeBadgeText = (node: DiscourseNode): string => {
+  return formatBadgeText(node.tag?.trim() || node.text);
+};
 
 const getTagStyle = (node: DiscourseNode | undefined): React.CSSProperties => {
   const color = node?.canvasSettings?.color;
@@ -102,7 +98,9 @@ const ResultRow = ({
     }}
   >
     <Tag minimal style={getTagStyle(nodeConfig)}>
-      {nodeConfig ? getNodeBadgeText(nodeConfig) : result.nodeTypeLabel}
+      {nodeConfig
+        ? getNodeBadgeText(nodeConfig)
+        : formatBadgeText(result.nodeTypeLabel)}
     </Tag>
     <span className="min-w-0 break-words text-sm leading-snug text-gray-900">
       {renderHighlightedText(stripTypePrefix(result.title), keywords)}

apps/roam/src/components/AdvancedNodeSearchDialog/utils.ts

@@ -68,6 +68,9 @@ export const formatMetadataDate = (value: string): string => {
   });
 };
 
+export const formatBadgeText = (text: string): string =>
+  text.replace(/^#/, "").slice(0, 3).toUpperCase();
+
 export const stripTypePrefix = (title: string): string => {
   const match = title.match(/^\[\[.*?\]\]\s*-\s*(.*)/s);
   return match ? match[1] : title;