ENG-1490 Fix ZodError in getAllDiscourseNodes for legacy block prop shapes (#856)

* ENG-1490 Fix ZodError in getAllDiscourseNodes for legacy block prop shapes

Migrate legacy discourse node block props on read instead of dropping
nodes that fail schema validation. Handles two known shape changes:
- specification: Condition[] → {enabled, query: {conditions, ...}}
- suggestiveRules.isFirstChild: {uid, value} → boolean

On successful migration, writes the fixed data back so subsequent reads
hit the happy path. Nodes that can't be migrated still report to PostHog.

* ENG-1490 Report post-migration error instead of pre-migration error

When migration fails, report retryResult.error (remaining issues) instead
of result.error (original issues) so PostHog shows actionable diagnostics.

* ENG-1490 Use correct returnNode default in migration

Set returnNode to "node" (matching DEFAULT_RETURN_NODE and IndexSchema
default) instead of "" which bypasses Zod's .default() and would persist
incorrect empty values for migrated nodes.

Author: sid597

apps/roam/src/components/settings/utils/accessors.ts

@@ -493,6 +493,67 @@ export const setDiscourseNodeSetting = (
   setBlockPropAtPath(pageUid, keys, value);
 };
 
+/**
+ * Migrate known legacy block prop shapes to the current schema.
+ *
+ * - specification: Condition[] → {enabled, query: {conditions, ...}}
+ * - specification: {enabled, query: Condition[]} → {enabled, query: {conditions, ...}}
+ * - suggestiveRules.isFirstChild: {uid, value} → boolean
+ */
+const migrateNodeBlockProps = (
+  props: Record<string, json>,
+): Record<string, json> => {
+  const migrated = { ...props };
+
+  if (Array.isArray(migrated.specification)) {
+    migrated.specification = {
+      enabled: migrated.specification.length > 0,
+      query: {
+        conditions: migrated.specification,
+        selections: [],
+        custom: "",
+        returnNode: "node",
+      },
+    };
+  } else if (
+    typeof migrated.specification === "object" &&
+    migrated.specification !== null &&
+    "query" in migrated.specification &&
+    Array.isArray((migrated.specification as Record<string, json>).query)
+  ) {
+    const spec = migrated.specification as Record<string, json>;
+    migrated.specification = {
+      enabled:
+        typeof spec.enabled === "boolean"
+          ? spec.enabled
+          : (spec.query as json[]).length > 0,
+      query: {
+        conditions: spec.query,
+        selections: [],
+        custom: "",
+        returnNode: "node",
+      },
+    };
+  }
+
+  if (
+    typeof migrated.suggestiveRules === "object" &&
+    migrated.suggestiveRules !== null &&
+    !Array.isArray(migrated.suggestiveRules)
+  ) {
+    const rules = migrated.suggestiveRules as Record<string, json>;
+    const ifc = rules.isFirstChild;
+    if (typeof ifc === "object" && ifc !== null && !Array.isArray(ifc)) {
+      migrated.suggestiveRules = {
+        ...rules,
+        isFirstChild: (ifc as Record<string, json>).value ?? false,
+      };
+    }
+  }
+
+  return migrated;
+};
+
 export const getAllDiscourseNodes = (): DiscourseNodeSettings[] => {
   const results = window.roamAlphaAPI.data.fast.q(`
     [:find ?uid ?title (pull ?page [:block/props])
@@ -517,20 +578,27 @@ export const getAllDiscourseNodes = (): DiscourseNodeSettings[] => {
     )
       continue;
 
+    const nodeText = title.replace(DISCOURSE_NODE_PAGE_PREFIX, "");
     const result = DiscourseNodeSchema.safeParse(blockProps);
     if (result.success) {
-      nodes.push({
-        ...result.data,
-        type: pageUid,
-        text: title.replace(DISCOURSE_NODE_PAGE_PREFIX, ""),
-      });
+      nodes.push({ ...result.data, type: pageUid, text: nodeText });
     } else {
-      internalError({
-        error: result.error,
-        type: "DG Discourse Node Parse",
-        context: { pageUid, title },
-        sendEmail: false,
-      });
+      // Try migrating legacy field shapes before dropping the node.
+      const migrated = migrateNodeBlockProps(
+        blockProps as Record<string, json>,
+      );
+      const retryResult = DiscourseNodeSchema.safeParse(migrated);
+      if (retryResult.success) {
+        setBlockProps(pageUid, retryResult.data, false);
+        nodes.push({ ...retryResult.data, type: pageUid, text: nodeText });
+      } else {
+        internalError({
+          error: retryResult.error,
+          type: "DG Discourse Node Parse",
+          context: { pageUid, title },
+          sendEmail: false,
+        });
+      }
     }
   }