fix review

Author: sid597

apps/roam/src/components/settings/LeftSidebarPersonalSettings.tsx

@@ -620,7 +620,7 @@ const LeftSidebarPersonalSectionsContent = ({
   const addSection = useCallback(
     async (sectionName: string) => {
       if (!sectionName || !personalSectionUid) return;
-      if (sections.some((s) => s.text === sectionName)) return;
+      if (sectionsRef.current.some((s) => s.text === sectionName)) return;
 
       try {
         const newBlock = await createBlock({
@@ -636,7 +636,7 @@ const LeftSidebarPersonalSectionsContent = ({
           children: undefined,
           childrenUid: undefined,
         } as LeftSidebarPersonalSectionConfig;
-        const updatedSections = [...sections, newSection];
+        const updatedSections = [...sectionsRef.current, newSection];
         setSections(updatedSections);
         syncAllSectionsToBlockProps(updatedSections);
 
@@ -653,7 +653,7 @@ const LeftSidebarPersonalSectionsContent = ({
         });
       }
     },
-    [personalSectionUid, sections],
+    [personalSectionUid],
   );
 
   const handleNewSectionInputChange = useCallback((value: string) => {

apps/roam/src/components/settings/utils/zodSchema.example.ts

@@ -276,40 +276,43 @@ const defaultGlobalSettings: GlobalSettings = {
 };
 
 const personalSection: PersonalSection = {
+  name: "My Workspace",
   Children: [
-    { Page: "daily-notes-uid", Alias: "Daily Notes" },
-    { Page: "inbox-uid", Alias: "Inbox" },
-    { Page: "projects-uid", Alias: "" },
+    { uid: "daily-notes-uid", Alias: "Daily Notes" },
+    { uid: "inbox-uid", Alias: "Inbox" },
+    { uid: "projects-uid", Alias: "" },
   ],
   Settings: {
     "Truncate-result?": 100,
     Folded: false,
   },
 };
 
-const leftSidebarPersonalSettings: LeftSidebarPersonalSettings = {
-  "My Workspace": {
+const leftSidebarPersonalSettings: LeftSidebarPersonalSettings = [
+  {
+    name: "My Workspace",
     Children: [
-      { Page: "daily-notes-uid", Alias: "Daily Notes" },
-      { Page: "inbox-uid", Alias: "Inbox" },
+      { uid: "daily-notes-uid", Alias: "Daily Notes" },
+      { uid: "inbox-uid", Alias: "Inbox" },
     ],
     Settings: {
       "Truncate-result?": 75,
       Folded: false,
     },
   },
-  Research: {
+  {
+    name: "Research",
     Children: [
-      { Page: "papers-uid", Alias: "Papers" },
-      { Page: "notes-uid", Alias: "Notes" },
-      { Page: "ideas-uid", Alias: "Ideas" },
+      { uid: "papers-uid", Alias: "Papers" },
+      { uid: "notes-uid", Alias: "Notes" },
+      { uid: "ideas-uid", Alias: "Ideas" },
     ],
     Settings: {
       "Truncate-result?": 50,
       Folded: true,
     },
   },
-};
+];
 
 const storedFilters: StoredFilters = {
   includes: { values: ["Claim", "Evidence"] },
@@ -333,28 +336,30 @@ const querySettings: QuerySettings = {
 };
 
 const personalSettings: PersonalSettings = {
-  "Left sidebar": {
-    "My Workspace": {
+  "Left sidebar": [
+    {
+      name: "My Workspace",
       Children: [
-        { Page: "daily-notes-uid", Alias: "Daily Notes" },
-        { Page: "inbox-uid", Alias: "Inbox" },
+        { uid: "daily-notes-uid", Alias: "Daily Notes" },
+        { uid: "inbox-uid", Alias: "Inbox" },
       ],
       Settings: {
         "Truncate-result?": 75,
         Folded: false,
       },
     },
-    Research: {
+    {
+      name: "Research",
       Children: [
-        { Page: "papers-uid", Alias: "Papers" },
-        { Page: "notes-uid", Alias: "Notes" },
+        { uid: "papers-uid", Alias: "Papers" },
+        { uid: "notes-uid", Alias: "Notes" },
       ],
       Settings: {
         "Truncate-result?": 50,
         Folded: true,
       },
     },
-  },
+  ],
   "Personal node menu trigger": ";;",
   "Node search menu trigger": "//",
   "Discourse tool shortcut": "d",
@@ -382,7 +387,7 @@ const personalSettings: PersonalSettings = {
 };
 
 const defaultPersonalSettings: PersonalSettings = {
-  "Left sidebar": {},
+  "Left sidebar": [],
   "Personal node menu trigger": "",
   "Node search menu trigger": "",
   "Discourse tool shortcut": "",