Refactor dev script to use async/await for better readability and error handling; update import of Octokit to CommonJS format in publish script; modify generateUid function to import nanoid as default. (#360)

Author: mdroidian

apps/obsidian/scripts/dev.ts

@@ -9,18 +9,17 @@ const dev = () => {
   return new Promise<number>((resolve) => {
     compile({
       opts: args,
-      builder: (opts: esbuild.BuildOptions) =>
-        esbuild.context(opts).then((esb) => {
-          esb.watch();
-          // Cleanup on process termination
-          const cleanup = () => {
-            esb.dispose();
-            resolve(0);
-          };
-          process.on('SIGINT', cleanup);
-          process.on('SIGTERM', cleanup);
-          return esb;
-        }),
+      builder: async (opts: esbuild.BuildOptions) => {
+        const esb = await esbuild.context(opts);
+        esb.watch();
+        // Cleanup on process termination
+        const cleanup = () => {
+          esb.dispose();
+          resolve(0);
+        };
+        process.on("SIGINT", cleanup);
+        process.on("SIGTERM", cleanup);
+      },
     });
     process.on("exit", resolve);
   });

apps/obsidian/scripts/publish.ts

@@ -3,7 +3,10 @@ import fs from "fs";
 import path from "path";
 import { exec } from "child_process";
 import util from "util";
-import { Octokit } from "@octokit/core";
+// https://linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+// TODO: Change to apps/obsidian to ESM
+// import { Octokit } from "@octokit/core";
+const { Octokit } = require("@octokit/core");
 import os from "os";
 
 dotenv.config();

apps/obsidian/src/utils/generateUid.ts

@@ -1,4 +1,4 @@
-import { nanoid } from "nanoid";
+import nanoid from "nanoid";
 
 const generateUid = (prefix = "dg") => {
   return `${prefix}_${nanoid()}`;