ENG-1454: Enable dual read feature flag

Author: sid597

apps/roam/src/components/settings/AdminPanel.tsx

@@ -39,6 +39,7 @@ import deleteBlock from "roamjs-components/writes/deleteBlock";
 import { USE_REIFIED_RELATIONS } from "~/data/userSettings";
 import posthog from "posthog-js";
 import { setFeatureFlag } from "~/components/settings/utils/accessors";
+import { FeatureFlagPanel } from "./components/BlockPropSettingPanels";
 
 const NodeRow = ({ node }: { node: PConceptFull }) => {
   return (
@@ -467,6 +468,12 @@ const FeatureFlagsTab = (): React.ReactElement => {
         }
       />
 
+      <FeatureFlagPanel
+        title="Enable dual read"
+        description="When enabled, accessor getters read from block props instead of the old system. Surfaces dual-write gaps during development."
+        featureKey="Enable dual read"
+      />
+
       <Button
         className="w-96"
         icon="send-message"

apps/roam/src/components/settings/utils/pullWatchers.ts

@@ -90,10 +90,13 @@ export const featureFlagHandlers: Partial<
     (newValue: boolean, oldValue: boolean, allFlags: FeatureFlags) => void
   >
 > = {
-  // Add handlers as needed:
-  // "Enable Left Sidebar": (newValue) => { ... },
-  // "Suggestive Mode Enabled": (newValue) => { ... },
-  // "Reified Relation Triples": (newValue) => { ... },
+  /* eslint-disable @typescript-eslint/naming-convention */
+  "Enable dual read": (newValue, oldValue) => {
+    console.log(
+      `[DG] Enable dual read: ${String(oldValue)} → ${String(newValue)}`,
+    );
+  },
+  /* eslint-enable @typescript-eslint/naming-convention */
 };
 
 type GlobalSettingsHandlers = {

apps/roam/src/components/settings/utils/zodSchema.ts

@@ -157,6 +157,7 @@ export const FeatureFlagsSchema = z.object({
   "Enable left sidebar": z.boolean().default(false),
   "Suggestive mode enabled": z.boolean().default(false),
   "Reified relation triples": z.boolean().default(false),
+  "Enable dual read": z.boolean().default(false),
 });
 
 export const ExportSettingsSchema = z.object({

apps/roam/src/index.ts

@@ -42,6 +42,7 @@ import {
   DISALLOW_DIAGNOSTICS,
 } from "./data/userSettings";
 import { initSchema } from "./components/settings/utils/init";
+import { setupPullWatchOnSettingsPage } from "./components/settings/utils/pullWatchers";
 export const DEFAULT_CANVAS_PAGE_FORMAT = "Canvas/*";
 
 export default runExtension(async (onloadArgs) => {
@@ -154,7 +155,8 @@ export default runExtension(async (onloadArgs) => {
     });
   }
 
-  await initSchema();
+  const { blockUids } = await initSchema();
+  const cleanupPullWatchers = setupPullWatchOnSettingsPage(blockUids);
 
   return {
     elements: [
@@ -166,6 +168,7 @@ export default runExtension(async (onloadArgs) => {
     ],
     observers: observers,
     unload: () => {
+      cleanupPullWatchers();
       setSyncActivity(false);
       window.roamjs.extension?.smartblocks?.unregisterCommand("QUERYBUILDER");
       // @ts-expect-error - tldraw throws a warning on multiple loads