Skip to content

Commit 5f4068e

Browse files
committed
fix, bug fixes, updates
1 parent 527ad87 commit 5f4068e

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ const DiscourseNodeCanvasSettings = ({ nodeType, uid }: { nodeType: string; uid:
9797
title="Key Image"
9898
description="Add an image to the discourse node"
9999
settingKeys={["canvasSettings", "key-image"]}
100-
defaultValue={false}
100+
defaultValue={isKeyImage}
101101
onChange={(checked) => {
102102
setIsKeyImage(checked);
103103
if (checked && !keyImageOption) setKeyImageOption("first-image");

apps/roam/src/components/settings/NodeConfig.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ const NodeConfig = ({
265265
description={`Describing what the ${node.text} node represents in your graph.`}
266266
settingKeys={["description"]}
267267
defaultValue={node.description}
268+
order={1}
268269
parentUid={node.type}
269270
uid={descriptionUid}
270271
/>
@@ -287,6 +288,7 @@ const NodeConfig = ({
287288
placeholder={generateTagPlaceholder(node)}
288289
validate={validateTag}
289290
onChange={setTagValue}
291+
order={2}
290292
parentUid={node.type}
291293
uid={tagUid}
292294
/>

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,7 @@ const BaseTextPanel = ({
128128
setValue(newValue);
129129
onChange?.(newValue);
130130

131-
const validationError = validate?.(newValue);
132-
setError(validationError);
133-
if (validationError) return;
131+
if (validate?.(newValue)) return;
134132

135133
window.clearTimeout(debounceRef.current);
136134
debounceRef.current = window.setTimeout(() => {

0 commit comments

Comments
 (0)