Correct sql spacing. (#313)

SQRuff issue [1786](quarylabs/sqruff#1786) was solved in sqruff 2.9.1
Re-enable rule LT01 accordingly, and re-apply linting to schema files.
Indicate the minimum version in the readme.

Author: maparent

packages/database/.sqruff

@@ -1,7 +1,7 @@
 [sqruff]
 dialect = postgres
 # Exclude LT01 until https://github.com/quarylabs/sqruff/issues/1786 is solved.
-exclude_rules = CP05,LT05,LT01
+exclude_rules = CP05,LT05
 
 [sqruff:indentation]
 indent_unit = space

packages/database/README.md

@@ -11,7 +11,7 @@ It does mean you will have a fresh database with minimal data.
 
 1. Install [Docker](https://www.docker.com)
 2. Set the `SUPABASE_WORKDIR` in your environment to the absolute path of the `packages/database` directory.
-3. Install [sqruff](https://github.com/quarylabs/sqruff)
+3. Install [sqruff](https://github.com/quarylabs/sqruff), version >= 0.29.1
 
 ### General usage:
 

packages/database/supabase/schemas/access_token.sql

@@ -37,7 +37,7 @@ REVOKE TRIGGER ON TABLE "public"."access_token" FROM "anon";
 GRANT SELECT ON TABLE "public"."access_token" TO "anon";
 GRANT INSERT ON TABLE "public"."access_token" TO "anon";
 
-ALTER TABLE public.access_token ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public.access_token ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS access_token_policy ON public.access_token ;
-CREATE POLICY access_token_policy ON public.access_token FOR ALL USING (public.my_account(platform_account_id)) ;
+DROP POLICY IF EXISTS access_token_policy ON public.access_token;
+CREATE POLICY access_token_policy ON public.access_token FOR ALL USING (public.my_account(platform_account_id));

packages/database/supabase/schemas/account.sql

@@ -142,7 +142,7 @@ AS $$
     SELECT dg_account = auth.uid() FROM public."PlatformAccount" WHERE id=account_id;
 $$;
 
-COMMENT ON FUNCTION public.my_account IS 'security utility: is this my own account?' ;
+COMMENT ON FUNCTION public.my_account IS 'security utility: is this my own account?';
 
 CREATE OR REPLACE FUNCTION public.in_space(space_id BIGINT) RETURNS boolean
 STABLE SECURITY DEFINER
@@ -154,20 +154,20 @@ AS $$
         WHERE sa.space_id = $1 AND pa.dg_account = auth.uid();
 $$;
 
-COMMENT ON FUNCTION public.in_space IS 'security utility: does current user have access to this space?' ;
+COMMENT ON FUNCTION public.in_space IS 'security utility: does current user have access to this space?';
 
 
-CREATE OR REPLACE FUNCTION public.account_in_shared_space (p_account_id BIGINT) RETURNS boolean
+CREATE OR REPLACE FUNCTION public.account_in_shared_space(p_account_id BIGINT) RETURNS boolean
 STABLE SECURITY DEFINER
 SET search_path = ''
 LANGUAGE sql AS $$
     SELECT COUNT(*) > 0 FROM public."PlatformAccount" AS my_account
         JOIN public."SpaceAccess" AS my_access ON (my_account.id=my_access.account_id)
         JOIN public."SpaceAccess" AS their_access ON (their_access.space_id = my_access.space_id AND their_access.account_id=p_account_id)
         WHERE my_account.dg_account = auth.uid();
-$$ ;
+$$;
 
-CREATE OR REPLACE FUNCTION public.unowned_account_in_shared_space (p_account_id BIGINT) RETURNS boolean
+CREATE OR REPLACE FUNCTION public.unowned_account_in_shared_space(p_account_id BIGINT) RETURNS boolean
 STABLE SECURITY DEFINER
 SET search_path = ''
 LANGUAGE sql AS $$
@@ -176,52 +176,52 @@ LANGUAGE sql AS $$
         JOIN public."SpaceAccess" AS their_access ON (their_access.space_id = my_access.space_id AND their_access.account_id=p_account_id)
         JOIN public."PlatformAccount" AS their_account ON (their_access.account_id = their_account.id AND their_account.id=p_account_id)
         WHERE my_account.dg_account = auth.uid() AND COALESCE(their_account.dg_account, auth.uid()) = auth.uid();
-$$ ;
+$$;
 
-COMMENT ON FUNCTION public.unowned_account_in_shared_space IS 'security utility: does current user share a space with this account? And is this an un-owned account (other than mine)?' ;
+COMMENT ON FUNCTION public.unowned_account_in_shared_space IS 'security utility: does current user share a space with this account? And is this an un-owned account (other than mine)?';
 
 
 -- Space: Allow anyone to insert, but only users who are members of the space can update or select
 
-ALTER TABLE public."Space" ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public."Space" ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS space_policy ON public."Space" ;
-CREATE POLICY space_policy ON public."Space" FOR ALL USING (public.in_space(id)) ;
+DROP POLICY IF EXISTS space_policy ON public."Space";
+CREATE POLICY space_policy ON public."Space" FOR ALL USING (public.in_space(id));
 
-DROP POLICY IF EXISTS space_insert_policy ON public."Space" ;
-CREATE POLICY space_insert_policy ON public."Space" FOR INSERT WITH CHECK (true) ;
+DROP POLICY IF EXISTS space_insert_policy ON public."Space";
+CREATE POLICY space_insert_policy ON public."Space" FOR INSERT WITH CHECK (true);
 
 -- PlatformAccount: Access to anyone sharing a space with you to create an account, to allow editing authors
 -- Once the account is claimed by a user, only allow this user to modify it.
 -- Eventually: Allow platform admin to modify?
 
-ALTER TABLE public."PlatformAccount" ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public."PlatformAccount" ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS platform_account_policy ON public."PlatformAccount" ;
-CREATE POLICY platform_account_policy ON public."PlatformAccount" FOR ALL USING (dg_account = (SELECT auth.uid()) OR (dg_account IS null AND public.unowned_account_in_shared_space(id))) ;
+DROP POLICY IF EXISTS platform_account_policy ON public."PlatformAccount";
+CREATE POLICY platform_account_policy ON public."PlatformAccount" FOR ALL USING (dg_account = (SELECT auth.uid()) OR (dg_account IS null AND public.unowned_account_in_shared_space(id)));
 
-DROP POLICY IF EXISTS platform_account_select_policy ON public."PlatformAccount" ;
-CREATE POLICY platform_account_select_policy ON public."PlatformAccount" FOR SELECT USING (dg_account = (SELECT auth.uid()) OR public.account_in_shared_space(id)) ;
+DROP POLICY IF EXISTS platform_account_select_policy ON public."PlatformAccount";
+CREATE POLICY platform_account_select_policy ON public."PlatformAccount" FOR SELECT USING (dg_account = (SELECT auth.uid()) OR public.account_in_shared_space(id));
 
 -- SpaceAccess: Created through the create_account_in_space and the Space create route, both of which bypass RLS.
 -- Can be updated by a space peer for now, unless claimed by a user.
 -- Eventually: Allow space admin to modify?
 
-ALTER TABLE public."SpaceAccess" ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public."SpaceAccess" ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS space_access_policy ON public."SpaceAccess" ;
-CREATE POLICY space_access_policy ON public."SpaceAccess" FOR ALL USING (public.unowned_account_in_shared_space(account_id)) ;
+DROP POLICY IF EXISTS space_access_policy ON public."SpaceAccess";
+CREATE POLICY space_access_policy ON public."SpaceAccess" FOR ALL USING (public.unowned_account_in_shared_space(account_id));
 
-DROP POLICY IF EXISTS space_access_select_policy ON public."SpaceAccess" ;
-CREATE POLICY space_access_select_policy ON public."SpaceAccess" FOR ALL USING (public.in_space(space_id)) ;
+DROP POLICY IF EXISTS space_access_select_policy ON public."SpaceAccess";
+CREATE POLICY space_access_select_policy ON public."SpaceAccess" FOR ALL USING (public.in_space(space_id));
 
 -- AgentIdentifier: Allow space members to do anything, to allow editing authors.
 -- Eventually: Once the account is claimed by a user, only allow this user to modify it.
 
-ALTER TABLE public."AgentIdentifier" ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public."AgentIdentifier" ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS agent_identifier_policy ON public."AgentIdentifier" ;
-CREATE POLICY agent_identifier_policy ON public."AgentIdentifier" FOR ALL USING (public.unowned_account_in_shared_space(account_id)) ;
+DROP POLICY IF EXISTS agent_identifier_policy ON public."AgentIdentifier";
+CREATE POLICY agent_identifier_policy ON public."AgentIdentifier" FOR ALL USING (public.unowned_account_in_shared_space(account_id));
 
-DROP POLICY IF EXISTS agent_identifier_select_policy ON public."AgentIdentifier" ;
-CREATE POLICY agent_identifier_select_policy ON public."AgentIdentifier" FOR SELECT USING (public.account_in_shared_space(account_id)) ;
+DROP POLICY IF EXISTS agent_identifier_select_policy ON public."AgentIdentifier";
+CREATE POLICY agent_identifier_select_policy ON public."AgentIdentifier" FOR SELECT USING (public.account_in_shared_space(account_id));

packages/database/supabase/schemas/concept.sql

@@ -254,7 +254,7 @@ BEGIN
 END;
 $$;
 
-CREATE OR REPLACE FUNCTION public.concept_in_space (concept_id BIGINT) RETURNS boolean
+CREATE OR REPLACE FUNCTION public.concept_in_space(concept_id BIGINT) RETURNS boolean
 STABLE
 SET search_path = ''
 LANGUAGE sql

packages/database/supabase/schemas/content.sql

@@ -496,7 +496,7 @@ $$;
 
 COMMENT ON FUNCTION public.upsert_content IS 'batch content upsert';
 
-CREATE OR REPLACE FUNCTION public.content_in_space (content_id BIGINT) RETURNS boolean
+CREATE OR REPLACE FUNCTION public.content_in_space(content_id BIGINT) RETURNS boolean
 STABLE
 SET search_path = ''
 LANGUAGE sql
@@ -506,7 +506,7 @@ $$;
 
 COMMENT ON FUNCTION public.content_in_space IS 'security utility: does current user have access to this content''s space?';
 
-CREATE OR REPLACE FUNCTION public.document_in_space (document_id BIGINT) RETURNS boolean
+CREATE OR REPLACE FUNCTION public.document_in_space(document_id BIGINT) RETURNS boolean
 STABLE
 SET search_path = ''
 LANGUAGE sql

packages/database/supabase/schemas/sync.sql

@@ -263,7 +263,7 @@ GRANT ALL ON FUNCTION public.get_nodes_needing_sync(nodes_from_roam jsonb) TO "a
 GRANT ALL ON FUNCTION public.get_nodes_needing_sync(nodes_from_roam jsonb) TO "service_role";
 
 
-CREATE OR REPLACE FUNCTION public.generic_entity_access (target_id BIGINT, target_type public."EntityType") RETURNS boolean
+CREATE OR REPLACE FUNCTION public.generic_entity_access(target_id BIGINT, target_type public."EntityType") RETURNS boolean
 STABLE SECURITY DEFINER
 SET search_path = ''
 LANGUAGE sql AS $$
@@ -275,16 +275,16 @@ LANGUAGE sql AS $$
         WHEN target_type = 'PlatformAccount' THEN public.account_in_shared_space(target_id)
         ELSE false
     END;
-$$ ;
+$$;
 
-COMMENT ON FUNCTION public.generic_entity_access IS 'security utility: does current user have access to this generic entity?' ;
+COMMENT ON FUNCTION public.generic_entity_access IS 'security utility: does current user have access to this generic entity?';
 
 
-ALTER TABLE public.sync_info ENABLE ROW LEVEL SECURITY ;
+ALTER TABLE public.sync_info ENABLE ROW LEVEL SECURITY;
 
 -- Assuming the sync target is a always a space for now
 
-DROP POLICY IF EXISTS sync_info_policy ON public.sync_info ;
-CREATE POLICY sync_info_policy ON public.sync_info FOR ALL USING (public.generic_entity_access(sync_target, target_type)) ;
+DROP POLICY IF EXISTS sync_info_policy ON public.sync_info;
+CREATE POLICY sync_info_policy ON public.sync_info FOR ALL USING (public.generic_entity_access(sync_target, target_type));
 
 RESET ALL;