Skip to content

Commit 83a18be

Browse files
authored
ENG-1063 add beta flag to global settings for Suggestive mode (#565)
* add beta flag to global settings * address coderabbit review
1 parent 9b64e0a commit 83a18be

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

apps/roam/src/components/settings/GeneralSettings.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@ const DiscourseGraphHome = () => {
3838
parentUid={settings.settingsUid}
3939
value={settings.leftSidebarEnabled.value || false}
4040
/>
41+
<FlagPanel
42+
title="(BETA) Suggestive Mode Enabled"
43+
description="Whether or not to enable the suggestive mode, if this is first time enabling it, you will need to generate and upload all node embeddings to supabase. Go to Suggestive Mode -> Sync Config -> Click on 'Generate & Upload All Node Embeddings'"
44+
order={3}
45+
uid={settings.suggestiveModeEnabled.uid}
46+
parentUid={settings.settingsUid}
47+
value={settings.suggestiveModeEnabled.value || false}
48+
/>
4149
</div>
4250
);
4351
};

apps/roam/src/components/settings/SuggestiveModeSettings.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,6 @@ const SuggestiveModeSettings = () => {
111111
});
112112
try {
113113
await createOrUpdateDiscourseEmbedding();
114-
await createBlock({
115-
parentUid: settings.settingsUid,
116-
node: { text: "(BETA) Suggestive Mode Enabled" },
117-
});
118114
} catch (e) {
119115
console.error("Failed to generate embeddings", e);
120116
renderToast({

apps/roam/src/utils/discourseConfigRef.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const getFormattedConfigTree = (): FormattedConfigTree => {
8080
}),
8181
suggestiveModeEnabled: getUidAndBooleanSetting({
8282
tree: configTreeRef.tree,
83-
text: "(BETA) Suggestive Mode",
83+
text: "(BETA) Suggestive Mode Enabled",
8484
}),
8585
};
8686
};

0 commit comments

Comments
 (0)