remove unnecessary checks zod takes care

Author: sid597

apps/roam/src/components/DiscourseNodeSearchMenu.tsx

@@ -709,7 +709,7 @@ export const renderDiscourseNodeSearchMenu = (props: Props) => {
 
 export const NodeSearchMenuTriggerSetting = () => {
   const [nodeSearchTrigger, setNodeSearchTriggerState] = useState<string>(
-    () => getPersonalSetting<string>(["Node Search Menu Trigger"]) ?? "@",
+    () => getPersonalSetting<string>(["Node Search Menu Trigger"])!,
   );
 
   const handleNodeSearchTriggerChange = (

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

@@ -28,36 +28,29 @@ export const formatHexColor = (color: string) => {
 
 const DiscourseNodeCanvasSettings = ({ nodeType }: { nodeType: string }) => {
   const [color, setColor] = useState<string>(() => {
-    const storedColor =
-      getDiscourseNodeSetting<string>(nodeType, ["canvasSettings", "color"]) ??
-      "";
+    const storedColor = getDiscourseNodeSetting<string>(nodeType, [
+      "canvasSettings",
+      "color",
+    ])!;
     return formatHexColor(storedColor);
   });
-  const [alias, setAlias] = useState<string>(
-    () =>
-      getDiscourseNodeSetting<string>(nodeType, ["canvasSettings", "alias"]) ??
-      "",
+  const [alias, setAlias] = useState<string>(() =>
+    getDiscourseNodeSetting<string>(nodeType, ["canvasSettings", "alias"])!,
+  );
+  const [queryBuilderAlias, setQueryBuilderAlias] = useState<string>(() =>
+    getDiscourseNodeSetting<string>(nodeType, [
+      "canvasSettings",
+      "query-builder-alias",
+    ])!,
   );
-  const [queryBuilderAlias, setQueryBuilderAlias] = useState<string>(
-    () =>
-      getDiscourseNodeSetting<string>(nodeType, [
-        "canvasSettings",
-        "query-builder-alias",
-      ]) ?? "",
+  const [isKeyImage, setIsKeyImage] = useState(() =>
+    getDiscourseNodeSetting<boolean>(nodeType, ["canvasSettings", "key-image"])!,
   );
-  const [isKeyImage, setIsKeyImage] = useState(() => {
-    const value = getDiscourseNodeSetting<boolean>(nodeType, [
+  const [keyImageOption, setKeyImageOption] = useState(() =>
+    getDiscourseNodeSetting<string>(nodeType, [
       "canvasSettings",
-      "key-image",
-    ]);
-    return value === true;
-  });
-  const [keyImageOption, setKeyImageOption] = useState(
-    () =>
-      getDiscourseNodeSetting<string>(nodeType, [
-        "canvasSettings",
-        "key-image-option",
-      ]) ?? "first-image",
+      "key-image-option",
+    ])!,
   );
 
   return (

apps/roam/src/components/settings/KeyboardShortcutInput.tsx

@@ -23,7 +23,7 @@ const KeyboardShortcutInput = ({
   const inputRef = useRef<HTMLInputElement>(null);
   const [isActive, setIsActive] = useState(false);
   const [shortcutKey, setShortcutKey] = useState<string>(
-    () => getPersonalSetting<string>([settingKey]) ?? "",
+    () => getPersonalSetting<string>([settingKey])!,
   );
 
   const handleKeyDown = useCallback(

apps/roam/src/utils/initializeObserversAndListeners.ts

@@ -329,8 +329,7 @@ export const initObservers = async ({
     }
   };
 
-  const customTrigger =
-    getPersonalSetting<string>(["Node Search Menu Trigger"]) ?? "@";
+  const customTrigger = getPersonalSetting<string>(["Node Search Menu Trigger"])!;
 
   const discourseNodeSearchTriggerListener = (e: Event) => {
     const evt = e as KeyboardEvent;