ENG-767 Roam tsc fixes (#359)

* Refactor CreateNodeDialog and ResultsTable to use consistent property naming; update concept ordering logic to utilize Set for missing concepts; enhance Supabase context error handling with user UID check.

* Refactor CommonJS imports to ESM in multiple scripts; update type imports and add local type definitions to avoid ESM issues. Addressed TODOs related to the transition to ESM in compile, publish, conceptConversion, and supabaseContext files.

* .

Author: mdroidian

apps/roam/scripts/compile.ts

@@ -2,7 +2,9 @@ import esbuild from "esbuild";
 import fs from "fs";
 import path from "path";
 import { z } from "zod";
-import { envContents } from "@repo/database/dbDotEnv";
+// https://linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+// import { envContents } from "@repo/database/dbDotEnv";
+const { envContents } = require("@repo/database/dbDotEnv");
 
 // https://github.com/evanw/esbuild/issues/337#issuecomment-954633403
 const importAsGlobals = (

apps/roam/scripts/publish.ts

@@ -3,8 +3,11 @@ import * as path from "path";
 import * as fs from "fs";
 import { exec } from "child_process";
 import util from "util";
-import { Octokit } from "@octokit/core";
-import { createAppAuth } from "@octokit/auth-app";
+// https://linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+// import { Octokit } from "@octokit/core";
+// import { createAppAuth } from "@octokit/auth-app";
+const { Octokit } = require("@octokit/core");
+const { createAppAuth } = require("@octokit/auth-app");
 
 dotenv.config();
 

apps/roam/src/components/CreateNodeDialog.tsx

@@ -96,6 +96,7 @@ const CreateNodeDialog = ({
               if (event.shiftKey) {
                 await window.roamAlphaAPI.ui.rightSidebar.addWindow({
                   window: {
+                    // @ts-expect-error TODO: fix this
                     "block-uid": newPageUid,
                     type: "outline",
                   },

apps/roam/src/components/results-view/ResultsTable.tsx

@@ -39,13 +39,13 @@ const ExtraContextRow = ({ uid }: { uid: string }) => {
       window.roamAlphaAPI.ui.components.renderPage({
         uid,
         el: containerRef.current,
-        hideMentions: true,
+        "hide-mentions?": true,
       });
     } else {
       window.roamAlphaAPI.ui.components.renderBlock({
         uid,
         el: containerRef.current,
-        zoomPath: true,
+        "zoom-path?": true,
       });
     }
   }, [containerRef, uid]);

apps/roam/src/utils/conceptConversion.ts

@@ -3,7 +3,11 @@ import getDiscourseRelations from "./getDiscourseRelations";
 import type { DiscourseRelation } from "./getDiscourseRelations";
 import type { SupabaseContext } from "~/utils/supabaseContext";
 
-import type { LocalConceptDataInput } from "@repo/database/inputTypes";
+// import type { LocalConceptDataInput } from "@repo/database/inputTypes";
+// TODO: Change to apps/roam to ESM and delete below
+// // linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+// Define the type locally to avoid ESM import issues
+type LocalConceptDataInput = any;
 
 const getNodeExtraData = (
   node_uid: string,
@@ -191,9 +195,10 @@ const orderConceptsRec = (
     if (relatedConcept === undefined) {
       missing.add(relatedConceptId);
     } else {
-      missing = missing.union(
-        orderConceptsRec(ordered, relatedConcept, remainder),
-      );
+      missing = new Set([
+        ...missing,
+        ...orderConceptsRec(ordered, relatedConcept, remainder),
+      ]);
       delete remainder[relatedConceptId];
     }
   }
@@ -225,7 +230,10 @@ export const orderConceptsByDependency = (
   let missing: Set<string> = new Set();
   while (Object.keys(conceptById).length > 0) {
     const first = Object.values(conceptById)[0];
-    missing = missing.union(orderConceptsRec(ordered, first, conceptById));
+    missing = new Set([
+      ...missing,
+      ...orderConceptsRec(ordered, first, conceptById),
+    ]);
   }
   return { ordered, missing: [...missing] };
 };

apps/roam/src/utils/supabaseContext.ts

@@ -3,16 +3,26 @@ import getCurrentUserDisplayName from "roamjs-components/queries/getCurrentUserD
 import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTitle";
 import getRoamUrl from "roamjs-components/dom/getRoamUrl";
 
-import type { Enums } from "@repo/database/dbTypes";
 import { DISCOURSE_CONFIG_PAGE_TITLE } from "~/utils/renderNodeConfigPage";
 import getBlockProps from "~/utils/getBlockProps";
 import setBlockProps from "~/utils/setBlockProps";
-import type { DGSupabaseClient } from "@repo/database/lib/client";
-import {
+// https://linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+// import type { Enums } from "@repo/database/dbTypes";
+// import type { DGSupabaseClient } from "@repo/database/lib/client";
+// import {
+//   fetchOrCreateSpaceDirect,
+//   fetchOrCreatePlatformAccount,
+//   createLoggedInClient,
+// } from "@repo/database/lib/contextFunctions";
+const {
   fetchOrCreateSpaceDirect,
   fetchOrCreatePlatformAccount,
   createLoggedInClient,
-} from "@repo/database/lib/contextFunctions";
+} = require("@repo/database/lib/contextFunctions");
+// TEMP TODO: Change to apps/roam to ESM
+// https://linear.app/discourse-graphs/issue/ENG-766/upgrade-all-commonjs-to-esm
+type DGSupabaseClient = any; // Supabase client type
+type Enums<T> = T extends "Platform" ? "Roam" | "Obsidian" : never;
 
 declare const crypto: { randomUUID: () => string };
 
@@ -51,6 +61,7 @@ export const getSupabaseContext = async (): Promise<SupabaseContext | null> => {
   if (_contextCache === null) {
     try {
       const accountLocalId = window.roamAlphaAPI.user.uid();
+      if (!accountLocalId) throw new Error("Could not get user UID");
       const spacePassword = getOrCreateSpacePassword();
       const personEmail = getCurrentUserEmail();
       const personName = getCurrentUserDisplayName();