move migrateImportedFromFrontMatter to sync

Author: maparent

apps/obsidian/src/index.ts

@@ -27,8 +27,6 @@ import { initializeSupabaseSync } from "~/utils/syncDgNodesToSupabase";
 import { FileChangeListener } from "~/utils/fileChangeListener";
 import generateUid from "~/utils/generateUid";
 import { migrateFrontmatterRelationsToRelationsJson } from "~/utils/relationsStore";
-import { collectDiscourseNodesFromVault } from "~/utils/getDiscourseNodes";
-import { spaceUriAndLocalIdToRid } from "~/utils/rid";
 
 export default class DiscourseGraphPlugin extends Plugin {
   settings: Settings = { ...DEFAULT_SETTINGS };
@@ -45,10 +43,6 @@ export default class DiscourseGraphPlugin extends Plugin {
       console.error("Failed to migrate frontmatter relations:", error);
     });
 
-    await this.migrateImportedFromFrontMatter().catch((error) => {
-      console.error("Failed to migrate frontmatter:", error);
-    });
-
     if (this.settings.syncModeEnabled === true) {
       void initializeSupabaseSync(this).catch((error) => {
         console.error("Failed to initialize Supabase sync:", error);
@@ -401,35 +395,6 @@ export default class DiscourseGraphPlugin extends Plugin {
     this.currentViewActions = [];
   }
 
-  async migrateImportedFromFrontMatter() {
-    const nodes = await collectDiscourseNodesFromVault(this, true);
-    for (const node of nodes) {
-      if (typeof node.frontmatter.importedFromSpaceUri === "string") {
-        await this.app.fileManager.processFrontMatter(
-          node.file,
-          (frontmatter: Record<string, unknown>) => {
-            const spaceUri = frontmatter.importedFromSpaceUri as string;
-            // note: we fortunately reused the original Id here.
-            const nodeId = frontmatter.nodeInstanceId;
-            if (typeof nodeId !== "string") {
-              console.error(
-                `error: missing nodeInstanceId on node ${node.file.path}`,
-              );
-              return;
-            }
-            try {
-              const rid = spaceUriAndLocalIdToRid(spaceUri, nodeId, "note");
-              frontmatter.importedFromRid = rid;
-              delete frontmatter.importedFromSpaceUri;
-            } catch (error) {
-              console.error(error);
-            }
-          },
-        );
-      }
-    }
-  }
-
   async onunload() {
     this.cleanupViewActions();
     if (this.styleElement) {

apps/obsidian/src/utils/syncDgNodesToSupabase.ts

@@ -21,6 +21,7 @@ import {
   type DiscourseNodeInVault,
   collectDiscourseNodesFromVault,
 } from "./getDiscourseNodes";
+import { spaceUriAndLocalIdToRid } from "./rid";
 
 const DEFAULT_TIME = "1970-01-01";
 export type ChangeType = "title" | "content";
@@ -780,6 +781,35 @@ export const cleanupOrphanedNodes = async (
   }
 };
 
+const migrateImportedFromFrontMatter = async (plugin: DiscourseGraphPlugin) => {
+  const nodes = await collectDiscourseNodesFromVault(plugin, true);
+  for (const node of nodes) {
+    if (typeof node.frontmatter.importedFromSpaceUri === "string") {
+      await plugin.app.fileManager.processFrontMatter(
+        node.file,
+        (frontmatter: Record<string, unknown>) => {
+          const spaceUri = frontmatter.importedFromSpaceUri as string;
+          // note: we fortunately reused the original Id here.
+          const nodeId = frontmatter.nodeInstanceId;
+          if (typeof nodeId !== "string") {
+            console.error(
+              `error: missing nodeInstanceId on node ${node.file.path}`,
+            );
+            return;
+          }
+          try {
+            const rid = spaceUriAndLocalIdToRid(spaceUri, nodeId, "note");
+            frontmatter.importedFromRid = rid;
+            delete frontmatter.importedFromSpaceUri;
+          } catch (error) {
+            console.error(error);
+          }
+        },
+      );
+    }
+  }
+};
+
 export const initializeSupabaseSync = async (
   plugin: DiscourseGraphPlugin,
 ): Promise<void> => {
@@ -790,6 +820,10 @@ export const initializeSupabaseSync = async (
     );
   }
 
+  await migrateImportedFromFrontMatter(plugin).catch((error) => {
+    console.error("Failed to migrate frontmatter:", error);
+  });
+
   await createOrUpdateDiscourseEmbedding(plugin, context).catch((error) => {
     new Notice(`Initial sync failed: ${error}`);
     console.error("Initial sync failed:", error);