ENG-1896 Remove legacy anchor-backed discourse node type support (#1135)

* Remove legacy anchor-backed discourse node type support

- Remove anchor-backed discourse node creation from getDiscourseNodes
- Remove anchor selection logic from getDiscourseContextResults
- Preserve existing context selection behavior

This removes unused legacy functionality where relations with 'anchor' in their triples would generate discourse nodes. Per the issue, this feature is no longer used and has no place to surface in the current discourse context UI.

* Refactor getDiscourseNodes to remove legacy relations parameter

- Updated getDiscourseNodes to only accept settingsSnapshot, removing the relations parameter.
- Adjusted multiple components and utility functions to align with the new getDiscourseNodes signature.
- Ensured consistent behavior across the application by standardizing how discourse nodes are retrieved.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: mdroidian

apps/roam/src/components/DiscourseContext.tsx

@@ -1,24 +1,6 @@
-import {
-  Button,
-  Icon,
-  Portal,
-  Switch,
-  Tabs,
-  Tab,
-  Tooltip,
-  Spinner,
-} from "@blueprintjs/core";
-import React, {
-  useCallback,
-  useEffect,
-  useMemo,
-  useState,
-  useRef,
-} from "react";
-import getPageTitleByPageUid from "roamjs-components/queries/getPageTitleByPageUid";
-import getShallowTreeByParentUid from "roamjs-components/queries/getShallowTreeByParentUid";
+import { Switch, Tabs, Tab, Spinner } from "@blueprintjs/core";
+import React, { useCallback, useEffect, useMemo, useState } from "react";
 import { Result } from "roamjs-components/types/query-builder";
-import nanoId from "nanoid";
 import getDiscourseContextResults from "~/utils/getDiscourseContextResults";
 import ResultsView from "./results-view/ResultsView";
 import posthog from "posthog-js";
@@ -34,188 +16,12 @@ type Props = {
   overlayRefresh?: () => void;
 };
 
-const ExtraColumnRow = (r: Result) => {
-  const [contextOpen, setContextOpen] = useState(false);
-  const [contextRowReady, setContextRowReady] = useState(false);
-  const contextId = useMemo(() => `td-${nanoId()}`, []);
-  const anchorId = useMemo(() => `td-${nanoId()}`, []);
-  const [anchorOpen, setAnchorOpen] = useState(false);
-  const [anchorRowReady, setAnchorRowReady] = useState(false);
-  const containerRef = useRef<HTMLSpanElement>(null);
-  const contextPageTitle = useMemo(
-    () =>
-      r["context-uid"] && getPageTitleByPageUid(r["context-uid"].toString()),
-    [r["context-uid"]],
-  );
-  const contextBreadCrumbs = useMemo(
-    () =>
-      r["context-uid"]
-        ? window.roamAlphaAPI
-            .q(
-              `[:find (pull ?p [:node/title :block/string :block/uid]) :where
-              [?b :block/uid "${r["context-uid"]}"]
-              [?b :block/parents ?p]
-            ]`,
-            )
-            .map(
-              (a) => a[0] as { string?: string; title?: string; uid: string },
-            )
-            .map((a) => ({ uid: a.uid, text: a.string || a.title || "" }))
-        : [],
-    [r["context-uid"]],
-  );
-  const contextChildren = useMemo(
-    () =>
-      r["context-uid"] && contextPageTitle
-        ? getShallowTreeByParentUid(r["context-uid"].toString()).map(
-            ({ uid }) => uid,
-          )
-        : [r["context-uid"].toString()],
-    [r["context-uid"], contextPageTitle, r.uid],
-  );
-  useEffect(() => {
-    if (contextOpen && containerRef.current) {
-      const row = containerRef.current.closest("tr");
-      const contextElement = document.createElement("tr");
-      const contextTd = document.createElement("td");
-      contextTd.colSpan = row?.childElementCount || 0;
-      contextElement.id = contextId;
-      row?.parentElement?.insertBefore(contextElement, row.nextElementSibling);
-      contextElement.append(contextTd);
-      setContextRowReady(true);
-    } else {
-      setContextRowReady(false);
-      document.getElementById(contextId)?.remove();
-    }
-  }, [contextOpen, setContextRowReady, contextId]);
-  useEffect(() => {
-    if (contextRowReady) {
-      setTimeout(() => {
-        contextChildren.forEach((uid) => {
-          const el = document.querySelector<HTMLElement>(
-            `tr#${contextId} div[data-uid="${uid}"]`,
-          );
-          if (el)
-            window.roamAlphaAPI.ui.components.renderBlock({
-              uid,
-              el,
-            });
-        });
-      }, 1);
-    }
-  }, [contextRowReady]);
-  useEffect(() => {
-    if (anchorOpen) {
-      const row = containerRef.current?.closest("tr");
-      const anchorElement = document.createElement("tr");
-      const anchorTd = document.createElement("td");
-      anchorTd.colSpan = row?.childElementCount || 0;
-      anchorElement.id = anchorId;
-      row?.parentElement?.insertBefore(anchorElement, row.nextElementSibling);
-      anchorElement.append(anchorTd);
-      setAnchorRowReady(true);
-    } else {
-      setAnchorRowReady(false);
-      document.getElementById(anchorId)?.remove();
-    }
-  }, [anchorOpen, setAnchorRowReady, anchorId]);
-  return (
-    <span ref={containerRef}>
-      {r["context-uid"] && (
-        <Tooltip content={"Context"}>
-          <Button
-            onClick={() => setContextOpen(!contextOpen)}
-            small
-            active={contextOpen}
-            style={{
-              opacity: 0.5,
-              fontSize: "0.8em",
-              ...(contextOpen
-                ? {
-                    opacity: 1,
-                    color: "#8A9BA8",
-                    backgroundColor: "#F5F8FA",
-                  }
-                : {}),
-            }}
-            minimal
-            icon="info-sign"
-          />
-        </Tooltip>
-      )}
-      <style>
-        {`#${contextId} td,
-#${anchorId} td {
-  position: relative;
-  background-color: #F5F8FA;
-  padding: 16px;
-  max-height: 240px;
-  overflow-y: scroll;
-}
-#${contextId} .bp3-portal,
-#${anchorId} .bp3-portal {
-  position: relative;
-}`}
-      </style>
-      {contextRowReady && (
-        <Portal
-          container={
-            document.getElementById(contextId)
-              ?.firstElementChild as HTMLDataElement
-          }
-          className={"relative"}
-        >
-          {contextPageTitle ? (
-            <h3 style={{ margin: 0 }}>{contextPageTitle}</h3>
-          ) : (
-            <div className="rm-zoom">
-              {contextBreadCrumbs.map((bc) => (
-                <div key={bc.uid} className="rm-zoom-item">
-                  <span className="rm-zoom-item-content">{bc.text}</span>
-                  <Icon icon={"chevron-right"} />
-                </div>
-              ))}
-            </div>
-          )}
-          {contextChildren.map((uid) => (
-            <div data-uid={uid} key={uid}></div>
-          ))}
-        </Portal>
-      )}
-      {r.anchor && (
-        <Tooltip content={"See Related Relations"}>
-          <Button
-            onClick={() => setAnchorOpen(!anchorOpen)}
-            active={anchorOpen}
-            small
-            style={{
-              opacity: 0.5,
-              fontSize: "0.8em",
-              ...(anchorOpen
-                ? {
-                    opacity: 1,
-                    color: "#8A9BA8",
-                    backgroundColor: "#F5F8FA",
-                  }
-                : {}),
-            }}
-            minimal
-            icon={"resolve"}
-          />
-        </Tooltip>
-      )}
-      {anchorRowReady && (
-        <Portal
-          container={
-            document.getElementById(anchorId)
-              ?.firstElementChild as HTMLDataElement
-          }
-        >
-          <ContextContent uid={r["anchor-uid"]} results={[]} />
-        </Portal>
-      )}
-    </span>
-  );
+const removeTargetFromResult = (
+  result: Partial<Result & { target: string }>,
+): Result => {
+  const tableResult = { ...result };
+  delete tableResult.target;
+  return tableResult as Result;
 };
 
 const ContextTab = ({
@@ -270,7 +76,7 @@ const ContextTab = ({
       // TODO - always save settings, but maybe separate from root `parentUid`?
       preventSavingSettings
       parentUid={parentUid}
-      results={Object.values(results).map(({ target, ...a }) => a as Result)}
+      results={Object.values(results).map(removeTargetFromResult)}
       columns={columns}
       onRefresh={onRefresh}
       header={

apps/roam/src/components/DiscourseContextOverlay.tsx

@@ -38,7 +38,7 @@ const getOverlayInfo = async (
 ): Promise<DiscourseData> => {
   try {
     const relations = getDiscourseRelations();
-    const nodes = getDiscourseNodes(relations);
+    const nodes = getDiscourseNodes();
 
     const [results, refs] = await Promise.all([
       getDiscourseContextResults({

apps/roam/src/components/DiscourseNodeMenu.tsx

@@ -62,9 +62,7 @@ const NodeMenu = ({
   );
   const userDiscourseNodes = useMemo(
     () =>
-      getDiscourseNodes(undefined, settingsSnapshot).filter(
-        (n) => n.backedBy === "user",
-      ),
+      getDiscourseNodes(settingsSnapshot).filter((n) => n.backedBy === "user"),
     [settingsSnapshot],
   );
   const discourseNodes = userDiscourseNodes.filter(

apps/roam/src/components/Export.tsx

@@ -327,7 +327,7 @@ const ExportDialog: ExportDialogComponent = ({
       );
       const allRelations = relations;
       const allRelationIds = allRelations.map((r) => r.id);
-      const allNodes = getDiscourseNodes(allRelations);
+      const allNodes = getDiscourseNodes();
       const allAddReferencedNodeByAction = (() => {
         const obj: AddReferencedNodeType = {};
 

apps/roam/src/components/SuggestionsBody.tsx

@@ -51,7 +51,7 @@ const getOverlayInfo = async (
   try {
     if (cache[tag]) return cache[tag];
 
-    const nodes = getDiscourseNodes(relations);
+    const nodes = getDiscourseNodes();
 
     const [results, refs] = await Promise.all([
       getDiscourseContextResults({

apps/roam/src/components/canvas/Tldraw.tsx

@@ -486,12 +486,12 @@ const TldrawCanvasShared = ({
     return Object.keys(discourseContext.relations);
   }, []);
   const allNodes = useMemo(() => {
-    const allNodes = getDiscourseNodes(allRelations);
+    const allNodes = getDiscourseNodes();
     discourseContext.nodes = Object.fromEntries(
       allNodes.map((n, index) => [n.type, { ...n, index }]),
     );
     return allNodes;
-  }, [allRelations]);
+  }, []);
 
   const allAddReferencedNodeByAction = useMemo(() => {
     const obj: AddReferencedNodeType = {};

apps/roam/src/utils/deriveDiscourseNodeAttribute.ts

@@ -47,7 +47,7 @@ const deriveNodeAttribute = async ({
   uid: string;
 }): Promise<string | number> => {
   const relations = getDiscourseRelations();
-  const nodes = getDiscourseNodes(relations);
+  const nodes = getDiscourseNodes();
   const discourseNode = findDiscourseNode({ uid, nodes });
   if (!discourseNode) return 0;
   const nodeType = discourseNode.type;

apps/roam/src/utils/findDiscourseNode.ts

@@ -27,7 +27,7 @@ const findDiscourseNode = ({
     return discourseNodeTypeCache[uid];
   }
 
-  const resolvedNodes = nodes ?? getDiscourseNodes(undefined, snapshot);
+  const resolvedNodes = nodes ?? getDiscourseNodes(snapshot);
   const matchingNode =
     resolvedNodes.find((node) =>
       title === undefined

apps/roam/src/utils/getDiscourseContextResults.ts

@@ -50,12 +50,6 @@ const buildSelections = ({
       label: "context",
       text: `node:${conditionUid}-Context`,
     });
-  } else if (r.triples.some((t) => t.some((a) => /anchor/i.test(a)))) {
-    selections.push({
-      uid: window.roamAlphaAPI.util.generateUID(),
-      label: "anchor",
-      text: `node:${conditionUid}-Anchor`,
-    });
   }
 
   return selections;
@@ -172,7 +166,7 @@ const buildQueryConfig = ({
 const getDiscourseContextResults = async ({
   uid: targetUid,
   relations = getDiscourseRelations(),
-  nodes = getDiscourseNodes(relations),
+  nodes = getDiscourseNodes(),
   ignoreCache,
   onResult,
 }: {