Skip to content

Commit d14ebe6

Browse files
mdroidiancursoragent
mdroidian
and
cursoragent
authored
Remove naming-convention eslint-disable comments from apps/obsidian (#1062)
- Removed all /* eslint-disable @typescript-eslint/naming-convention */ comments - Relaxed naming convention rules in base ESLint config now handle these cases - Verified no new lint warnings are introduced Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent 172f335 commit d14ebe6

16 files changed

Lines changed: 0 additions & 45 deletions

‎apps/obsidian/scripts/compile.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @typescript-eslint/naming-convention */
21
import esbuild from "esbuild";
32
import fs from "fs";
43
import path from "path";

‎apps/obsidian/src/components/AdminPanelSettings.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,11 @@ export const AdminPanelSettings = () => {
5454
new Notice("Failed to connect to the database", 3000);
5555
return;
5656
}
57-
/* eslint-disable @typescript-eslint/naming-convention */
5857
const { access_token, refresh_token } = sessionData.data.session;
5958
const { data, error } = await client.rpc("create_secret_token", {
6059
v_payload: JSON.stringify({ access_token, refresh_token }),
6160
expiry_interval: "45s",
6261
});
63-
/* eslint-enable @typescript-eslint/naming-convention */
6462
if (error || typeof data !== "string") {
6563
new Notice("Failed to connect to the database", 3000);
6664
return;

‎apps/obsidian/src/components/canvas/TldrawViewComponent.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ export const TldrawPreviewComponent = ({
428428
},
429429
}}
430430
components={{
431-
/* eslint-disable @typescript-eslint/naming-convention */
432431
ContextMenu: (props) => (
433432
<CustomContextMenu canvasFile={file} props={props} />
434433
),

‎apps/obsidian/src/components/canvas/stores/assetStore.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,6 @@ export class ObsidianTLAssetStore implements Required<TLAssetStore> {
341341

342342
resolve = async (
343343
asset: TLAsset,
344-
// eslint-disable-next-line @typescript-eslint/naming-convention
345344
_ctx: TLAssetContext,
346345
): Promise<string | null> => {
347346
try {

‎apps/obsidian/src/components/canvas/utils/relationUtils.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ https://github.com/tldraw/tldraw/tree/main/packages/tldraw/src/lib/shapes/arrow
1313
/* eslint-disable max-params */
1414
/* eslint-disable @typescript-eslint/no-unnecessary-type-assertion */
1515
/* eslint-disable preferArrows/prefer-arrow-functions */
16-
/* eslint-disable @typescript-eslint/naming-convention */
1716

1817
import React, { useRef, useEffect, useState } from "react";
1918
import {

‎apps/obsidian/src/components/canvas/utils/tldraw.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ import { DiscourseRelationBindingUtil } from "~/components/canvas/shapes/Discour
3030
import { discourseNodeMigrations } from "~/components/canvas/shapes/discourseNodeMigrations";
3131

3232
export type TldrawPluginMetaData = {
33-
/* eslint-disable @typescript-eslint/naming-convention */
3433
"plugin-version": string;
3534
"tldraw-version": string;
3635
uuid: string;
37-
/* eslint-disable @typescript-eslint/naming-convention */
3836
};
3937

4038
export type TldrawRawData = {

‎apps/obsidian/src/services/QueryEngine.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export class QueryEngine {
2828
query: (query: string) => DatacorePage[];
2929
}
3030
| undefined;
31-
// eslint-disable-next-line @typescript-eslint/naming-convention
3231
private readonly MIN_QUERY_LENGTH = 2;
3332

3433
constructor(app: App) {

‎apps/obsidian/src/utils/conceptConversion.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import type { Json } from "@repo/database/dbTypes";
1616
*/
1717
const getNodeExtraData = (
1818
file: TFile,
19-
/* eslint-disable @typescript-eslint/naming-convention */
2019
author_id: number,
2120
): {
2221
author_id: number;
@@ -28,7 +27,6 @@ const getNodeExtraData = (
2827
created: new Date(file.stat.ctime).toISOString(),
2928
last_modified: new Date(file.stat.mtime).toISOString(),
3029
};
31-
/* eslint-enable @typescript-eslint/naming-convention */
3230
};
3331

3432
export const discourseNodeSchemaToLocalConcept = ({
@@ -50,7 +48,6 @@ export const discourseNodeSchemaToLocalConcept = ({
5048
importedFromRid,
5149
...otherData
5250
} = node;
53-
/* eslint-disable @typescript-eslint/naming-convention */
5451
const literal_content: Record<string, Json> = {
5552
label: name,
5653
source_data: otherData,
@@ -68,7 +65,6 @@ export const discourseNodeSchemaToLocalConcept = ({
6865
last_modified: new Date(modified).toISOString(),
6966
description: description,
7067
literal_content,
71-
/* eslint-enable @typescript-eslint/naming-convention */
7268
};
7369
};
7470

@@ -89,18 +85,15 @@ export const discourseRelationTypeToLocalConcept = (
8985
status, //destructuring status to not upload it to the database
9086
...otherData
9187
} = relationType;
92-
// eslint-disable-next-line @typescript-eslint/naming-convention
9388
const literal_content: Record<string, Json> = {
9489
roles: STANDARD_ROLES,
9590
label,
9691
complement,
97-
// eslint-disable-next-line @typescript-eslint/naming-convention
9892
source_data: otherData,
9993
};
10094
if (importedFromRid) literal_content.importedFromRid = importedFromRid;
10195

10296
return {
103-
/* eslint-disable @typescript-eslint/naming-convention */
10497
space_id: context.spaceId,
10598
name: label,
10699
source_local_id: id,
@@ -109,7 +102,6 @@ export const discourseRelationTypeToLocalConcept = (
109102
created: new Date(created).toISOString(),
110103
last_modified: new Date(modified).toISOString(),
111104
literal_content,
112-
/* eslint-enable @typescript-eslint/naming-convention */
113105
};
114106
};
115107

@@ -138,7 +130,6 @@ export const discourseRelationTripleSchemaToLocalConcept = ({
138130
const relationType = relationTypesById[relationshipTypeId];
139131
if (!relationType) return null;
140132
const { label, complement } = relationType;
141-
// eslint-disable-next-line @typescript-eslint/naming-convention
142133
const literal_content: Record<string, Json> = {
143134
roles: STANDARD_ROLES,
144135
label,
@@ -147,7 +138,6 @@ export const discourseRelationTripleSchemaToLocalConcept = ({
147138
if (importedFromRid) literal_content.importedFromRid = importedFromRid;
148139

149140
return {
150-
/* eslint-disable @typescript-eslint/naming-convention */
151141
space_id: context.spaceId,
152142
name: `${sourceName} -${label}-> ${destinationName}`,
153143
source_local_id: id,
@@ -161,7 +151,6 @@ export const discourseRelationTripleSchemaToLocalConcept = ({
161151
source: sourceId,
162152
destination: destinationId,
163153
},
164-
/* eslint-enable @typescript-eslint/naming-convention */
165154
};
166155
};
167156

@@ -175,23 +164,19 @@ export const discourseNodeInstanceToLocalConcept = (
175164
const extraData = getNodeExtraData(nodeData.file, context.userId);
176165
const { nodeInstanceId, nodeTypeId, importedFromRid, ...otherData } =
177166
nodeData.frontmatter;
178-
// eslint-disable-next-line @typescript-eslint/naming-convention
179167
const literal_content: Record<string, Json> = {
180168
label: nodeData.file.basename,
181-
// eslint-disable-next-line @typescript-eslint/naming-convention
182169
source_data: otherData as unknown as Json,
183170
};
184171
if (importedFromRid && typeof importedFromRid === "string")
185172
literal_content.importedFromRid = importedFromRid;
186173
return {
187-
/* eslint-disable @typescript-eslint/naming-convention */
188174
space_id: context.spaceId,
189175
name: nodeData.file.path,
190176
source_local_id: nodeInstanceId as string,
191177
schema_represented_by_local_id: nodeTypeId as string,
192178
is_schema: false,
193179
literal_content,
194-
/* eslint-enable @typescript-eslint/naming-convention */
195180
...extraData,
196181
};
197182
};
@@ -222,7 +207,6 @@ export const relationInstanceToLocalConcept = ({
222207
return null;
223208
}
224209

225-
/* eslint-disable @typescript-eslint/naming-convention */
226210
const literal_content: Record<string, Json> = {};
227211
if (importedFromRid) literal_content.importedFromRid = importedFromRid;
228212
return {
@@ -243,7 +227,6 @@ export const relationInstanceToLocalConcept = ({
243227
(destinationNode.frontmatter.importedFromRid as string | undefined) ??
244228
destination,
245229
},
246-
/* eslint-enable @typescript-eslint/naming-convention */
247230
};
248231
};
249232

‎apps/obsidian/src/utils/importNodes.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @typescript-eslint/naming-convention */
21
import type { Json } from "@repo/database/dbTypes";
32
import matter from "gray-matter";
43
import { App, Notice, TFile } from "obsidian";

‎apps/obsidian/src/utils/importPreview.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @typescript-eslint/naming-convention */
21
import type DiscourseGraphPlugin from "~/index";
32
import type { ImportableNode } from "~/types";
43
import { getLoggedInClient, getSupabaseContext } from "./supabaseContext";

0 commit comments

Comments
 (0)