remove console.logs

Author: sid597

apps/roam/src/components/settings/utils/accessors.ts

@@ -942,235 +942,3 @@ export const getAllDiscourseNodes = (): DiscourseNodeSettings[] => {
 
   return nodes;
 };
-
-type DualReadProbeCase = { keys: string[] };
-
-type DualReadProbeNodeCase = {
-  nodeType: string;
-  keys: string[];
-};
-
-type DualReadProbeItem = {
-  scope: "personal" | "global" | "discourseNode";
-  keys: string[];
-  nodeType?: string;
-  legacyValue?: unknown;
-  blockPropsValue?: unknown;
-  legacyError?: string;
-  blockPropsError?: string;
-  match: boolean;
-};
-
-const normalizeProbeError = (error: unknown): string => {
-  return error instanceof Error ? error.message : String(error);
-};
-
-const safeSerialize = (value: unknown): string => {
-  try {
-    return JSON.stringify(value);
-  } catch {
-    return String(value);
-  }
-};
-
-const normalizeForComparison = (value: unknown): unknown => {
-  if (Array.isArray(value)) {
-    return value.map(normalizeForComparison);
-  }
-  if (isRecord(value)) {
-    return Object.keys(value)
-      .sort()
-      .reduce<Record<string, unknown>>((acc, key) => {
-        acc[key] = normalizeForComparison(value[key]);
-        return acc;
-      }, {});
-  }
-  return value;
-};
-
-const runProbeRead = (
-  reader: () => unknown,
-): {
-  value?: unknown;
-  error?: string;
-} => {
-  try {
-    return { value: reader() };
-  } catch (error) {
-    return { error: normalizeProbeError(error) };
-  }
-};
-
-const hasProbeMatch = ({
-  legacyError,
-  blockPropsError,
-  legacyValue,
-  blockPropsValue,
-}: {
-  legacyError?: string;
-  blockPropsError?: string;
-  legacyValue?: unknown;
-  blockPropsValue?: unknown;
-}): boolean => {
-  if (legacyError || blockPropsError) return false;
-  return (
-    safeSerialize(normalizeForComparison(legacyValue)) ===
-    safeSerialize(normalizeForComparison(blockPropsValue))
-  );
-};
-
-const DEFAULT_DISCOURSE_NODE_PROBE_TYPE = "Claim";
-const DEFAULT_DISCOURSE_NODE_PROBE_KEYS: string[][] = [
-  ["description"],
-  ["shortcut"],
-  ["tag"],
-  ["index"],
-  ["format"],
-  ["specification", "enabled"],
-  ["specification", "query"],
-  ["template"],
-  ["attributes"],
-  ["overlay"],
-  ["canvasSettings", "color"],
-  ["canvasSettings", "alias"],
-  ["canvasSettings", "key-image"],
-  ["canvasSettings", "key-image-option"],
-  ["canvasSettings", "query-builder-alias"],
-  ["graphOverview"],
-  ["suggestiveRules", "embeddingRef"],
-  ["suggestiveRules", "isFirstChild"],
-];
-
-export const runDualReadProbe = ({
-  personalCases = [
-    { keys: ["Discourse context overlay"] },
-    { keys: ["Suggestive mode overlay"] },
-    { keys: ["Text selection popup"] },
-    { keys: ["Disable sidebar open"] },
-    { keys: ["Page preview"] },
-    { keys: ["Hide feedback button"] },
-    { keys: ["Auto canvas relations"] },
-    { keys: ["Overlay in canvas"] },
-    { keys: ["Streamline styling"] },
-    { keys: ["Disable product diagnostics"] },
-    { keys: ["Discourse tool shortcut"] },
-    { keys: ["Personal node menu trigger"] },
-    { keys: ["Node search menu trigger"] },
-    { keys: ["Query"] },
-    { keys: ["Query", "Hide query metadata"] },
-    { keys: ["Query", "Default page size"] },
-    { keys: ["Query", "Query pages"] },
-    { keys: ["Query", "Default filters"] },
-    { keys: ["Left sidebar"] },
-  ],
-  globalCases = [
-    { keys: ["Trigger"] },
-    { keys: ["Canvas page format"] },
-    { keys: ["Left sidebar"] },
-    { keys: ["Left sidebar", "Children"] },
-    { keys: ["Left sidebar", "Settings", "Collapsable"] },
-    { keys: ["Left sidebar", "Settings", "Folded"] },
-    { keys: ["Export"] },
-    { keys: ["Export", "Remove special characters"] },
-    { keys: ["Export", "Resolve block references"] },
-    { keys: ["Export", "Resolve block embeds"] },
-    { keys: ["Export", "Append referenced node"] },
-    { keys: ["Export", "Link type"] },
-    { keys: ["Export", "Max filename length"] },
-    { keys: ["Export", "Frontmatter"] },
-    { keys: ["Suggestive mode"] },
-    { keys: ["Suggestive mode", "Include current page relations"] },
-    { keys: ["Suggestive mode", "Include parent and child blocks"] },
-    { keys: ["Suggestive mode", "Page groups"] },
-    { keys: ["Relations"] },
-  ],
-  discourseNodeCases = DEFAULT_DISCOURSE_NODE_PROBE_KEYS.map((keys) => ({
-    nodeType: DEFAULT_DISCOURSE_NODE_PROBE_TYPE,
-    keys,
-  })),
-}: {
-  personalCases?: DualReadProbeCase[];
-  globalCases?: DualReadProbeCase[];
-  discourseNodeCases?: DualReadProbeNodeCase[];
-} = {}) => {
-  const rows: DualReadProbeItem[] = [];
-
-  personalCases.forEach(({ keys }) => {
-    const legacy = runProbeRead(() => getLegacyPersonalSetting(keys));
-    const blockProps = runProbeRead(() =>
-      readPathValue(getPersonalSettings(), keys),
-    );
-    rows.push({
-      scope: "personal",
-      keys,
-      legacyValue: legacy.value,
-      blockPropsValue: blockProps.value,
-      legacyError: legacy.error,
-      blockPropsError: blockProps.error,
-      match: hasProbeMatch({
-        legacyError: legacy.error,
-        blockPropsError: blockProps.error,
-        legacyValue: legacy.value,
-        blockPropsValue: blockProps.value,
-      }),
-    });
-  });
-
-  globalCases.forEach(({ keys }) => {
-    const legacy = runProbeRead(() => getLegacyGlobalSetting(keys));
-    const blockProps = runProbeRead(() =>
-      readPathValue(getGlobalSettings(), keys),
-    );
-    rows.push({
-      scope: "global",
-      keys,
-      legacyValue: legacy.value,
-      blockPropsValue: blockProps.value,
-      legacyError: legacy.error,
-      blockPropsError: blockProps.error,
-      match: hasProbeMatch({
-        legacyError: legacy.error,
-        blockPropsError: blockProps.error,
-        legacyValue: legacy.value,
-        blockPropsValue: blockProps.value,
-      }),
-    });
-  });
-
-  discourseNodeCases.forEach(({ nodeType, keys }) => {
-    const legacy = runProbeRead(() =>
-      getLegacyDiscourseNodeSetting(nodeType, keys),
-    );
-    const blockProps = runProbeRead(() =>
-      readPathValue(getDiscourseNodeSettings(nodeType), keys),
-    );
-    rows.push({
-      scope: "discourseNode",
-      nodeType,
-      keys,
-      legacyValue: legacy.value,
-      blockPropsValue: blockProps.value,
-      legacyError: legacy.error,
-      blockPropsError: blockProps.error,
-      match: hasProbeMatch({
-        legacyError: legacy.error,
-        blockPropsError: blockProps.error,
-        legacyValue: legacy.value,
-        blockPropsValue: blockProps.value,
-      }),
-    });
-  });
-
-  const mismatches = rows.filter((row) => !row.match);
-
-  return {
-    dualReadEnabled: isDualReadEnabled(),
-    summary: {
-      total: rows.length,
-      matches: rows.filter((row) => row.match).length,
-      mismatches: mismatches.length,
-    },
-    rows,
-    mismatches,
-  };
-};

apps/roam/src/index.ts

@@ -43,7 +43,6 @@ import {
 } from "./data/userSettings";
 import { initSchema } from "./components/settings/utils/init";
 import { setupPullWatchOnSettingsPage } from "./components/settings/utils/pullWatchers";
-import { runDualReadProbe } from "./components/settings/utils/accessors";
 export const DEFAULT_CANVAS_PAGE_FORMAT = "Canvas/*";
 
 export default runExtension(async (onloadArgs) => {
@@ -125,10 +124,6 @@ export default runExtension(async (onloadArgs) => {
   }
 
   const { extensionAPI } = onloadArgs;
-  const debugWindow = window as unknown as { [key: string]: unknown };
-  debugWindow["__DG_DEBUG__"] = {
-    runDualReadProbe,
-  };
   window.roamjs.extension.queryBuilder = {
     runQuery: (parentUid: string) =>
       runQuery({ parentUid, extensionAPI }).then(