Remove naming-convention eslint-disable comments from apps/roam (#1064)

- Removed all /* eslint-disable @typescript-eslint/naming-convention */ comments
- Removed all // eslint-disable-next-line @typescript-eslint/naming-convention comments
- Removed all // eslint-disable-line @typescript-eslint/naming-convention comments
- No new lint warnings introduced - relaxed naming rules from ENG-1777 are working correctly

Relates to ENG-1779

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: mdroidian

apps/roam/src/components/CreateRelationDialog.tsx

@@ -373,7 +373,6 @@ export const renderCreateRelationDialog = (
     });
   } else {
     renderOverlay({
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       Overlay: CreateRelationDialog,
       props: props as ExtendedCreateRelationDialogProps,
     });

apps/roam/src/components/DiscourseNodeSearchMenu.tsx

@@ -297,9 +297,7 @@ const NodeSearchMenu = ({
   const { ["block-uid"]: blockUid, ["window-id"]: windowId } = useMemo(
     () =>
       window.roamAlphaAPI.ui.getFocusedBlock() || {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         "block-uid": "",
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         "window-id": "",
       },
     [],
@@ -352,9 +350,7 @@ const NodeSearchMenu = ({
               if (window.roamAlphaAPI.ui.setBlockFocusAndSelection) {
                 void window.roamAlphaAPI.ui.setBlockFocusAndSelection({
                   location: {
-                    // eslint-disable-next-line @typescript-eslint/naming-convention
                     "block-uid": blockUid,
-                    // eslint-disable-next-line @typescript-eslint/naming-convention
                     "window-id": windowId,
                   },
                   selection: { start: newCursorPosition },

apps/roam/src/components/Export.tsx

@@ -250,7 +250,6 @@ const ExportDialog: ExportDialogComponent = ({
     setSelectedPageUid(getPageUidByPageTitle(title));
   };
 
-  /* eslint-disable @typescript-eslint/naming-convention */
   const addToSelectedCanvas = async (pageUid: string) => {
     if (typeof results !== "object") return false;
 
@@ -283,7 +282,6 @@ const ExportDialog: ExportDialogComponent = ({
               if (event.shiftKey) {
                 void window.roamAlphaAPI.ui.rightSidebar.addWindow({
                   // @ts-expect-error - todo test
-                  // eslint-disable-next-line @typescript-eslint/naming-convention
                   window: { "block-uid": pageUid, type: "outline" },
                 });
               } else {
@@ -420,7 +418,6 @@ const ExportDialog: ExportDialogComponent = ({
       tldraw.schema = tlStore.schema.serialize();
       tempTlStoreSnapshot = tlStore.getStoreSnapshot();
     }
-    /* eslint-disable @typescript-eslint/naming-convention */
 
     const tlStoreSnapshot = isTLStore
       ? (tldraw as TLStoreSnapshot) // isTlStore type checked above
@@ -677,7 +674,6 @@ const ExportDialog: ExportDialogComponent = ({
                 if (event.shiftKey) {
                   void window.roamAlphaAPI.ui.rightSidebar.addWindow({
                     // @ts-expect-error - todo test
-                    // eslint-disable-next-line @typescript-eslint/naming-convention
                     window: { "block-uid": uid, type: "outline" },
                   });
                 } else {

apps/roam/src/components/LeftSidebarCommands.tsx

@@ -17,7 +17,6 @@ export const commands: Record<
   (onloadArgs: OnloadArgs) => Promise<void>
 > = {
   /* eslint-disable @typescript-eslint/require-await */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   "{create node}": async (onloadArgs: OnloadArgs) => {
     createDiscourseNodeFromCommand(onloadArgs.extensionAPI);
     // typescript-eslint/naming-convention

apps/roam/src/components/LeftSidebarView.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import React, {
   useCallback,
   useEffect,
@@ -119,7 +118,6 @@ const openTarget = async (
   if (e.shiftKey) {
     await window.roamAlphaAPI.ui.rightSidebar.addWindow({
       // @ts-expect-error - todo test
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       window: { type: "outline", "block-uid": targetUid },
     });
   } else {

apps/roam/src/components/ModifyNodeDialog.tsx

@@ -322,7 +322,6 @@ const ModifyNodeDialog = ({
           extensionAPI,
           parentUid,
           // due to query format
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           inputs: { NODETEXT: content.text, NODEUID: pageUid },
         });
         const imagePlaceholderUid = results.allProcessedResults[0]?.uid;
@@ -398,7 +397,6 @@ const ModifyNodeDialog = ({
           formattedTitle = nodeFormat.replace(
             /{([\w\d-]*)}/g,
             // unused variable will take _ as name
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             (_, val: string) => {
               if (/content/i.test(val)) return content.text.trim();
               if (new RegExp(referencedNode.name, "i").test(val))
@@ -460,7 +458,6 @@ const ModifyNodeDialog = ({
                       await window.roamAlphaAPI.ui.rightSidebar.addWindow({
                         window: {
                           // @ts-expect-error TODO: fix this
-                          // eslint-disable-next-line @typescript-eslint/naming-convention
                           "block-uid": newPageUid,
                           type: "outline",
                         },
@@ -492,7 +489,6 @@ const ModifyNodeDialog = ({
         if (referencedNode && referencedNodeValue.text) {
           updatedContent = nodeFormat
             // unused variable will take _ as name
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             .replace(/{([\w\d-]*)}/g, (_, val: string) => {
               if (/content/i.test(val)) return content.text.trim();
               if (new RegExp(referencedNode.name, "i").test(val))
@@ -643,7 +639,6 @@ const ModifyNodeDialog = ({
 
 export const renderModifyNodeDialog = (props: ModifyNodeDialogProps) =>
   renderOverlay({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     Overlay: ModifyNodeDialog,
     props,
   });

apps/roam/src/components/VectorDuplicateMatches.tsx

@@ -92,7 +92,6 @@ export const VectorDuplicateMatches = ({
       window: {
         type: "outline",
         // @ts-expect-error - type definition mismatch
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         "block-uid": node.uid,
       },
     });

apps/roam/src/components/canvas/Clipboard.tsx

@@ -84,7 +84,6 @@ type ClipboardContextValue = {
   setShowNodesOnCanvas: (show: boolean) => void;
 };
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 const ClipboardContext = createContext<ClipboardContextValue | null>(null);
 
 const CLIPBOARD_PROP_KEY = "pages";
@@ -109,9 +108,7 @@ const getOrCreateClipboardBlock = async (
     childBlocksData?.[":block/children"] &&
     Array.isArray(childBlocksData[":block/children"])
       ? (childBlocksData[":block/children"] as Array<{
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           ":block/uid": string;
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           ":block/string": string;
         }>)
       : [];

apps/roam/src/components/canvas/CustomDefaultToolbar.tsx

@@ -1,6 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */
 /* eslint-disable @typescript-eslint/consistent-type-definitions */
-/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable preferArrows/prefer-arrow-functions */
 
 // from /packages/tldraw/src/lib/ui/components/Toolbar/DefaultToolbar.tsx

apps/roam/src/components/canvas/DiscourseNodeUtil.tsx

@@ -76,7 +76,6 @@ export const DEFAULT_STYLE_PROPS = {
 };
 export const COLOR_ARRAY = Array.from(DefaultColorStyle.values).reverse();
 // from @tldraw/editor/editor.css
-/* eslint-disable @typescript-eslint/naming-convention */
 export const COLOR_PALETTE: Record<string, string> = {
   black: "#1d1d1d",
   blue: "#4263eb",
@@ -92,7 +91,6 @@ export const COLOR_PALETTE: Record<string, string> = {
   white: "#ffffff",
   yellow: "#ffc078",
 };
-/* eslint-disable @typescript-eslint/naming-convention */
 
 const getRelationIds = () =>
   new Set(