ENG-1723 backend function: List group members#1026
Merged
Conversation
|
Updates to Preview Branch (eng-1723-backend-function-list-group-members) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
3 times, most recently
from
51acade to
ea1b7e4
Compare
mdroidian
requested changes
May 15, 2026
mdroidian
left a comment
mdroidian
left a comment
Member
There was a problem hiding this comment.
As discussed, we'll be replacing the UI used for testing the backend function with vitest
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
6996593 to
3edcb8b
Compare
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
2 times, most recently
from
5a4ae16 to
c36e158
Compare
maparent
force-pushed
the
eng-1758-vitest-infrastructure
branch
from
4a8f9bd to
8fde609
Compare
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
c36e158 to
2a4e1d0
Compare
maparent
force-pushed
the
eng-1758-vitest-infrastructure
branch
from
8fde609 to
a5c951e
Compare
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
2a4e1d0 to
d8d63ec
Compare
maparent
force-pushed
the
eng-1758-vitest-infrastructure
branch
from
a5c951e to
66a8fe4
Compare
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
d8d63ec to
4e187d0
Compare
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
4e187d0 to
5fcd009
Compare
Collaborator
Author
|
A note on PR size: In theory we're over 200, but in practice many changes are in dbTypes.ts (generated) and the changes in the migration repeat those in account.sql, so they do not need separate review. If we just look at account.sql and the tests, we're at 210 LoC. |
maparent
force-pushed
the
eng-1723-backend-function-list-group-members
branch
from
f8473bf to
f861893
Compare
Collaborator
Author
|
|
mdroidian
reviewed
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1723/backend-function-list-group-members
https://www.loom.com/share/6540d774efd040ff8cd508e95f190a93