ENG-1702 Invite new members in the group by maparent · Pull Request #1027 · DiscourseGraphs/discourse-graph

maparent · 2026-05-13T01:42:32Z

https://linear.app/discourse-graphs/issue/ENG-1702/invite-new-members-in-the-group

One loom covers eng-1720, eng-1702 and vitest-web
https://www.loom.com/share/4dc27a35953340058f9227638e63ff62

linear-code · 2026-05-13T01:42:36Z

supabase · 2026-05-13T01:42:46Z

Updates to Preview Branch (eng-1702-invite-new-members-in-the-group) ↗︎

Deployments	Status	Updated
Database	✅	Thu, 21 May 2026 13:24:47 UTC
Services	✅	Thu, 21 May 2026 13:24:47 UTC
APIs	✅	Thu, 21 May 2026 13:24:47 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	✅	Thu, 21 May 2026 13:24:52 UTC
Migrations	✅	Thu, 21 May 2026 13:24:53 UTC
Seeding	✅	Thu, 21 May 2026 13:24:53 UTC
Edge Functions	✅	Thu, 21 May 2026 13:24:56 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

graphite-app · 2026-05-13T11:06:56Z

PR size/scope check

This PR is over our review-size guideline.

Recommended: ~200 lines changed
Acceptable limit: up to 400 lines when well-scoped/self-contained
Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

What single problem this PR solves
Why the files/changes are coupled

maparent · 2026-05-13T23:18:01Z

Note: I could make it smaller by separating the cucumber test if desired.

mdroidian

Guard dg_account before deleting users - packages/database/features/step-definitions/stepdefs.ts:83-83 Because Supabase's .not(...) call does not narrow the generated row type, dg_account is still string | null here; client.auth.admin.deleteUser requires a string, so pnpm --filter @repo/database check-types now reports TS2345 on this line.
Use the existing secret token schema path - packages/database/supabase/config.toml:55-55. There is no packages/database/supabase/schemas/secret_token.sql; the schema file in is secret_tokens.sql.

mdroidian

Re-triggering this "request changes" as GitHub/linear didn't catch it.

maparent · 2026-05-20T15:14:32Z

Ready for re-review (the git state does not show the option?)

mdroidian · 2026-05-20T21:23:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94dd94522d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mdroidian

Also see llm review comments

maparent marked this pull request as draft May 13, 2026 01:44

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch from 9eef582 to 2163640 Compare May 13, 2026 01:50

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch 6 times, most recently from b15b58b to 80ff57e Compare May 13, 2026 19:25

maparent changed the base branch from main to eng-1720-create-a-group May 13, 2026 20:20

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch from c0175f1 to 4c20a6c Compare May 13, 2026 20:22

maparent marked this pull request as ready for review May 13, 2026 23:15

maparent requested review from mdroidian May 13, 2026 23:18

mdroidian requested changes May 15, 2026

View reviewed changes

Comment thread apps/website/app/utils/supabase/account.ts Outdated

mdroidian requested changes May 15, 2026

View reviewed changes

maparent force-pushed the eng-1720-create-a-group branch from a521de0 to 07fdfc6 Compare May 15, 2026 13:30

Base automatically changed from eng-1720-create-a-group to main May 15, 2026 13:33

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch 2 times, most recently from d781fa8 to f66dac8 Compare May 17, 2026 19:36

maparent changed the base branch from main to eng-1719-list-groups-im-a-member-of May 17, 2026 19:40

maparent force-pushed the eng-1719-list-groups-im-a-member-of branch from 319e2c6 to dea6c28 Compare May 18, 2026 11:21

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch from f66dac8 to eeef2c6 Compare May 18, 2026 11:22

graphite-app Bot reviewed May 18, 2026

View reviewed changes

Comment thread packages/database/supabase/migrations/20260512201942_accept_group_invite.sql

maparent force-pushed the eng-1719-list-groups-im-a-member-of branch from dea6c28 to f3988c5 Compare May 18, 2026 13:48

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch from eeef2c6 to 888a126 Compare May 18, 2026 13:49

maparent force-pushed the eng-1719-list-groups-im-a-member-of branch from f3988c5 to 7d5a53a Compare May 18, 2026 19:43

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch 2 times, most recently from 894bfd6 to 0774593 Compare May 19, 2026 16:27

maparent force-pushed the eng-1719-list-groups-im-a-member-of branch from 7d5a53a to c07b6d5 Compare May 19, 2026 16:27

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch 2 times, most recently from c077293 to fe1cf5d Compare May 20, 2026 14:54

graphite-app Bot reviewed May 20, 2026

View reviewed changes

Comment thread apps/website/app/utils/supabase/account.ts

graphite-app Bot reviewed May 20, 2026

View reviewed changes

Comment thread apps/website/app/utils/supabase/account.ts Outdated

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread packages/database/supabase/migrations/20260512201942_accept_group_invite.sql

mdroidian approved these changes May 21, 2026

View reviewed changes

Comment thread apps/website/test/integration/groupInvitation.test.ts

Comment thread apps/website/app/utils/supabase/account.ts

Base automatically changed from eng-1719-list-groups-im-a-member-of to main May 21, 2026 12:51

maparent added 9 commits May 21, 2026 08:56

eng-1702-invite-new-member

fcd3560

Cucumber test for invitations, generated by Claude

a125ae2

correction to web

cb1acc0

Forgot to add secret_token to supabase/config

7c49ec5

linting

72cdf47

prettier

8b2dc9f

group invitation test

9bfb534

check token type; filename typo

7d1742b

add the database tag to the test

3843ceb

maparent force-pushed the eng-1702-invite-new-members-in-the-group branch from 94dd945 to 3843ceb Compare May 21, 2026 12:58

maparent added 2 commits May 21, 2026 08:59

rename test file

49df288

Review corrections

4ed39e8

maparent merged commit 43b82a8 into main May 21, 2026
11 checks passed

maparent deleted the eng-1702-invite-new-members-in-the-group branch May 21, 2026 13:27

Uh oh!

Conversation

maparent commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented May 13, 2026

Uh oh!

supabase Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app Bot commented May 13, 2026

PR size/scope check

Uh oh!

maparent commented May 13, 2026

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maparent commented May 20, 2026

Uh oh!

Uh oh!

Uh oh!

mdroidian commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maparent commented May 13, 2026 •

edited

Loading

supabase Bot commented May 13, 2026 •

edited

Loading