Remove naming-convention comments from packages/database#1061
Merged
mdroidian merged 5 commits intoMay 21, 2026
Conversation
- Removed all @typescript-eslint/naming-convention disable comments - Updated files: createEnv.mts, stepdefs.ts, dbDotEnv.mjs, contextFunctions.ts, queries.ts, files.ts, create-group/index.ts - Verified no new lint warnings were introduced - Related to ENG-1782
|
Updates to Preview Branch (cursor/remove-naming-convention-comments-database-d186) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
- Line 132 in stepdefs.ts had a no-unsafe-assignment comment, not naming-convention - Only naming-convention comments should be removed per ENG-1782
- Restored @typescript-eslint/no-explicit-any in files.ts - Restored @typescript-eslint/no-unsafe-member-access comments in contextFunctions.ts - Only naming-convention comments should be removed per ENG-1782
mdroidian
deleted the
cursor/remove-naming-convention-comments-database-d186
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes all
/* eslint-disable @typescript-eslint/naming-convention */comments frompackages/database.This is a follow-up to the relaxed base ESLint naming-convention rules, which now allow:
Changes
Removed eslint-disable comments from the following files:
packages/database/scripts/createEnv.mtspackages/database/features/step-definitions/stepdefs.tspackages/database/src/dbDotEnv.mjspackages/database/src/lib/contextFunctions.tspackages/database/src/lib/queries.tspackages/database/src/lib/files.tspackages/database/supabase/functions/create-group/index.tsTesting
✅ Ran
pnpm run lintinpackages/database- no new warnings introduced✅ All previously suppressed code now passes with the relaxed rules
Impact
Linear Issue: ENG-1782