ENG-1791 Obsidian sync does not recover from Concept upsert failure#1070
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-1791-obsidian-sync-does-not-recover-from-concept-upsert-failure
branch
from
699aa2f to
fb2fc57
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| .order("id"), | ||
| 1000, | ||
| ); | ||
| if (Array.isArray(existingConceptIds)) { |
There was a problem hiding this comment.
sorry for the late review. i'll approve first to unblock for this particular bug.
but given our latest convos about wrapping upsert_concept and upsert_content in one transaction, I wonder if we should do a more thorough missing check for both concepts and content -> upload whatever is missing. because otherwise we're doing a patch for a bug without being systematic about the root cause.
we can mark it as a clear TODO here for the next step.
| context.spaceId, | ||
| ); | ||
| const changedNodes: ObsidianDiscourseNodeData[] = []; | ||
| let missing: Set<string> | undefined; |
There was a problem hiding this comment.
nit: name to missing_concepts for clarify.
we should also add a comment explaining how this address a particular bug
maparent
deleted the
eng-1791-obsidian-sync-does-not-recover-from-concept-upsert-failure
branch
2 participants
https://linear.app/discourse-graphs/issue/ENG-1791/obsidian-sync-does-not-recover-from-concept-upsert-failure
https://www.loom.com/share/6c7c93bb2def43bd93722ab1cafd6938