Skip to content

ENG-1822 Modify upsert_concepts so it accepts embedded content#1097

Merged
maparent merged 7 commits into
mainfrom
eng-1822-modify-upsert-concepts-to-accept-embedded-content
Jun 2, 2026
Merged

ENG-1822 Modify upsert_concepts so it accepts embedded content#1097
maparent merged 7 commits into
mainfrom
eng-1822-modify-upsert-concepts-to-accept-embedded-content

Conversation

@maparent

@maparent maparent commented May 30, 2026

Copy link
Copy Markdown
Collaborator

https://linear.app/discourse-graphs/issue/ENG-1822/modify-upsert-concepts-so-it-accepts-embedded-content

https://www.loom.com/share/cb4e428ed0d647208a78a70fc31b734b

Forgot a point in the loom: The changes to the functions are such that it can still be called exactly as before without changes.


Open in Devin Review

@linear-code

linear-code Bot commented May 30, 2026

Copy link
Copy Markdown

ENG-1822

@graphite-app

graphite-app Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@supabase

supabase Bot commented May 30, 2026

Copy link
Copy Markdown

Updates to Preview Branch (eng-1822-modify-upsert-concepts-to-accept-embedded-content) ↗︎

Deployments Status Updated
Database Tue, 02 Jun 2026 03:07:10 UTC
Services Tue, 02 Jun 2026 03:07:10 UTC
APIs Tue, 02 Jun 2026 03:07:10 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Tue, 02 Jun 2026 03:07:13 UTC
Migrations Tue, 02 Jun 2026 03:07:13 UTC
Seeding Tue, 02 Jun 2026 03:07:13 UTC
Edge Functions Tue, 02 Jun 2026 03:07:18 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@maparent

maparent commented May 30, 2026

Copy link
Copy Markdown
Collaborator Author

Note on size: The core of the line count that requires analysis is in concept.sql (81l). This is then duplicated in the migration, propagated to dbTypes. The new types propagate on inputTypes.
addConcept.feature is shuffled to exercise the new code, but it's mostly block moves.
The documentation was made into a compilable ts file; more reorg than changes.
Then small changes to use common types in roam sync and fix discrepancies.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/database/supabase/schemas/concept.sql
@maparent maparent requested a review from mdroidian May 30, 2026 14:58
@maparent maparent force-pushed the eng-1822-modify-upsert-concepts-to-accept-embedded-content branch from f23596d to dc1f4a1 Compare June 2, 2026 03:06
@maparent maparent merged commit 4247a3f into main Jun 2, 2026
11 checks passed
@maparent maparent deleted the eng-1822-modify-upsert-concepts-to-accept-embedded-content branch June 2, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants