fix: remove leading '#' from search result tags#1114
Draft
mdroidian wants to merge 1 commit into
Draft
Conversation
- Import existing getCleanTagText utility function - Use it in getNodeBadgeText to strip '#' prefix before slicing - Fixes issue where tags showed as '#CL' instead of 'CLM' and '#QU' instead of 'QUE' Resolves ENG-1839
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the advanced search dialog, discourse node type tags were displaying with the "#" prefix included. For example:
This was because the
getNodeBadgeTextfunction was taking the first 3 characters ofnode.tag, which includes the "#" prefix.Solution
getCleanTagTextutility function from~/components/settings/NodeConfiggetNodeBadgeTextto strip the "#" prefix (and handle other cleanup) before taking the first 3 charactersTesting
Resolves Linear issue ENG-1839
Linear Issue: ENG-1839