ENG-1840: Align advanced search highlight with Roam/BlueprintJS#1117
Open
trangdoan982 wants to merge 3 commits into
Open
ENG-1840: Align advanced search highlight with Roam/BlueprintJS#1117trangdoan982 wants to merge 3 commits into
trangdoan982 wants to merge 3 commits into
Conversation
Replace custom purple selection chrome with Blueprint menu-item hover gray for result rows and native active states for filter/sort toolbar buttons. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Remove unnecessary querySelector type assertion and unused useMemo import. Co-authored-by: Cursor <cursoragent@cursor.com>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
mdroidian
approved these changes
Jun 12, 2026
mdroidian
left a comment
mdroidian
left a comment
Member
There was a problem hiding this comment.
Is there no way to do this with built in params/tailwind colors? Seems odd that we have to code in the exact rgba for on hover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor