Skip to content

ENG-1842 Strip block uids from stored templates to fix template editing #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 1 commit into from
Jun 15, 2026
Merged

ENG-1842 Strip block uids from stored templates to fix template editing #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/roam/src/components/settings/utils/zodSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export const IndexSchema = z.object({
type RoamNode = {
text: string;
children?: RoamNode[];
uid?: string;

@sid597 sid597 Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing uid here fixes ENG-1842:

  • RoamNodeSchema is only used for DiscourseNodeSchema.template
  • The optional uid let migration store legacy template trees with their block uids in block props
  • ENG-1454: Base getter() task #828's Template panel seeds an ephemeral buffer from that stored template → create-block replays the old uids → Block already exists (the originals still live under legacy Template) → buffer never created → panel dead. Shipped in v0.19.0, hence "suddenly broken"
  • Nothing reads template uids from the store: panel save (serializeBlockTree) and createBlocksFromTemplate (stripTemplateUids) both strip them already
  • Zod drops unknown keys on parse, so removal fixes both directions:
    • read: already-poisoned graphs get clean templates immediately, no data migration
    • write: future migrations store uid-free
  • Alternative was stripping in EphemeralBlocksPanel, but that patches one consumer and leaves the next one to hit the same landmine
  • Legacy mode (flag off) reads the live block tree and never touches this schema; fresh graphs were never poisoned

heading?: 0 | 1 | 2 | 3;
open?: boolean;
};
Expand All @@ -66,7 +65,6 @@ export const RoamNodeSchema: z.ZodType<RoamNode> = z.lazy(() =>
z.object({
text: z.string(),
children: RoamNodeSchema.array().optional(),
uid: z.string().optional(),
heading: z
.union([z.literal(0), z.literal(1), z.literal(2), z.literal(3)])
.optional(),
Expand Down