Skip to content

ENG-1635: Change key image setting from checkbox to toggle switch #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid597 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENG-1635: Change key image setting from checkbox to toggle switch #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions apps/obsidian/src/components/NodeTypeSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,14 @@ const BooleanField = ({
onChange: (value: boolean) => void;
disabled?: boolean;
}) => (
<input
type="checkbox"
checked={!!value}
onChange={(e) => onChange((e.target as HTMLInputElement).checked)}
disabled={disabled}
/>
<div
className={`checkbox-container ${value ? "is-enabled" : ""}`}
onClick={() => {
if (!disabled) onChange(!value);
}}
>
<input type="checkbox" checked={!!value} disabled={disabled} />

@devin-ai-integration devin-ai-integration Bot Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Controlled checkbox missing readOnly prop causes React console warning

The <input type="checkbox" checked={!!value} /> at line 166 is a controlled React input (it has checked prop) but lacks both onChange and readOnly. React will emit a console warning: "You provided a checked prop to a form field without an onChange handler. This will render a read-only field. If the field should be mutable use defaultChecked. Otherwise, set either onChange or readOnly."

The existing pattern in RelationshipSection.tsx:615 correctly adds readOnly to suppress this warning. The fix is to add readOnly to the input element.

Suggested change
<input type="checkbox" checked={!!value} disabled={disabled} />
<input type="checkbox" checked={!!value} readOnly disabled={disabled} />
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

</div>
);

const TextField = ({
Expand Down