-
Notifications
You must be signed in to change notification settings - Fork 6
FEE-823 Make BRAT repository URLs copyable on installation docs page #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,14 @@ published: true | |
| 2. Go to "Community Plugins" β "BRAT" | ||
| 3. Click "Add Beta Plugin" | ||
|  | ||
| 4. Enter the repository URL: `https://github.com/blacksmithgu/datacore` and choose "Latest version" | ||
|  | ||
| 4. Enter the repository URL below and choose "Latest version" | ||
|
|
||
| ``` | ||
| https://github.com/blacksmithgu/datacore | ||
| ``` | ||
|
Comment on lines
+26
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π© Markdown list continuity broken by unindented code blocks The refactored installation instructions place the code blocks (lines 26-28 and 43-45) at the root indentation level rather than indented under list item 4. In CommonMark, this breaks the ordered list into two separate lists (items 1-4, then a new list starting at 5). Visually the numbers still render as 5 and 6 because CommonMark respects the starting number, so the user-facing impact is minimal. However, the list semantics are broken, and some renderers may add extra spacing between the two lists. Indenting the code blocks by 4 spaces (or 3 to match the list prefix width) would keep them as part of list item 4 and maintain a single continuous list. Was this helpful? React with π or π to provide feedback. |
||
|
|
||
|  | ||
|
|
||
| 5. Check the box for "Enable after installing the plugin" | ||
| 6. Click "Add plugin" | ||
|
|
||
|
|
@@ -32,7 +38,13 @@ published: true | |
| 2. Go to "Community Plugins" β "BRAT" | ||
| 3. Click "Add Beta Plugin" | ||
|  | ||
| 4. Enter the repository URL: `https://github.com/DiscourseGraphs/discourse-graph-obsidian` and choose "Latest version" | ||
|  | ||
| 4. Enter the repository URL below and choose "Latest version" | ||
|
|
||
| ``` | ||
| https://github.com/DiscourseGraphs/discourse-graph-obsidian | ||
| ``` | ||
|
|
||
|  | ||
|
|
||
| 5. Check the box for "Enable after installing the plugin" | ||
| 6. Click "Add Plugin" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Hardcoded
text-orange-500bypasses the design system color tokensThe footer copyright text was changed from
text-secondary(#5F57C0) totext-orange-500(#f97316), a raw Tailwind utility color. The shared tailwind config (packages/tailwind-config/tailwind.config.ts) defines design tokens (primary: #FF8C4B,secondary: #5F57C0), and the entire codebase consistently uses these tokens (e.g.,text-primary,text-secondary). This is the only usage oftext-orange-500in the website app, violating the AGENTS.md rule to "Maintain visual consistency with the host application's design system." If the intent was to use an orange color,text-primaryshould be used instead.Was this helpful? React with π or π to provide feedback.