[ENG-1851] Add Roam single-node publish action#1132
Open
sid597 wants to merge 7 commits into
Open
Conversation
Add a 'DG: Share current node' command-palette action, gated on isSyncEnabled(). It deterministically captures the current page's discourse node (page uid = source-local id), validates it via findDiscourseNode, and opens the existing Share Data dialog with exactly one node. The Publish-tab handoff (initialPanel: "publish") is deferred to ENG-1890, which owns Export.tsx's initialPanel union and the tab; finishing it is a one-line change to the exportRender call here. Mirrors Obsidian's publish-discourse-node command and Roam's exportCurrentPage.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
sid597
changed the base branch from
main
to
eng-1890-add-publish-tab-to-roam-query-results-share-dialog
sid597
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ENG-1851 is now stacked on ENG-1890 and wires Roam single-node publishing into the existing Share Data dialog.
DG: Share current nodefor the current user-backed discourse node.Publishbutton on discourse node pages.Publishtab with exactly one selected node.Publishand the discourse context overlay render side by side, while full-width panels such as Possible Duplicates remain below.Test result
Built and copied the Roam extension bundle to
/mnt/data/projects/dg-test-eng-1851with Supabase env loaded.Runtime test:
[[NOD]] - test page 3via the page-titlePublishbutton.WIsbIYJIA.1a752508-6281-4270-a5ef-3a23cbfc047c.105833.Supabase verification:
ResourceAccessexists for selected node UIDWIsbIYJIAand group1a752508-6281-4270-a5ef-3a23cbfc047c.SpaceAccess.permissions = partialexists for the same group and space.lwEYjIASO(NODE 1).This proves the actual publish path rather than duplicate-node/vector-search behavior, because duplicate detection may use synced concepts/content/embeddings but does not create
ResourceAccessorSpaceAccessgroup grants.Scope note
This validates ENG-1851's action/wiring and group-scoped publish grant behavior. Full cross-user discovery/consumption remains ENG-1854 validation territory.