ENG-1136: Notify user when suggestive mode suggestion is adopted (Roam)#1145
Open
trangdoan982 wants to merge 8 commits into
Open
ENG-1136: Notify user when suggestive mode suggestion is adopted (Roam)#1145trangdoan982 wants to merge 8 commits into
trangdoan982 wants to merge 8 commits into
Conversation
When a user adopts a suggestion in Suggestive Mode: - Shows a toast "Added to [[Page Name]]" if the target page is already open in the main window or if sidebar navigation is disabled - Opens the target page in the right sidebar (or brings it to the top if already open) otherwise - Shows a toast confirming the created relation when a reified relation is adopted instead of a block Adds a new `notifySuggestiveModeAdoption` utility to keep notification logic separate from `SuggestionsBody`. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Only add notifySuggestiveModeAdopted at the end of the success path; don't restructure the existing if/else branches. Co-authored-by: Cursor <cursoragent@cursor.com>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
- Replace "adopted/adoption" naming with "added" throughout - Split single export with discriminated union into two direct functions: notifyBlockSuggestionAdded and notifyRelationSuggestionAdded - Inline one-off helpers: getSidebarWindows, findOutlineSidebarWindowId, resolveTargetPageUid - Merge bringSidebarWindowToTop + focusTopSidebarOutline into one focusSidebarOutline(windowId?, delayMs?), removing the buggy global fallback selector when a specific windowId is targeted - Share a single showSuggestionToast for both toast paths Co-authored-by: Cursor <cursoragent@cursor.com>
getCurrentPageUid() only parses the URL hash which can be stale or incorrect when a block is focused. Use the official Roam API getOpenPageOrBlockUid() (awaited properly since the caller is already async) and resolve the result to a page uid before comparing. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add comment to empty catch block to satisfy no-empty ESLint rule - Wrap suggestion-added notifications in try/catch so posthog tracking and suggestion list removal still run if sidebar/toast logic fails Co-authored-by: Cursor <cursoragent@cursor.com>
…ggested-node-is-added-to
- Use relation wording for success toast in block-adoption path when showing feedback in main window/disableSidebarOpen mode - Ensure sidebar-open path always targets outline windows and focuses the specific opened window so it is brought to the top Co-authored-by: Cursor <cursoragent@cursor.com>
Comment on lines
+81
to
+83
| showSuggestionToast( | ||
| `Added relation between [[${sourceTitle}]] and [[${destinationTitle}]]`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Wrong toast message for block suggestions.
The toast says "Added relation between..." but this function handles block suggestions, not relation suggestions. According to the PR description, it should show: Added to [[Page Name]].
The message should reference the destination page, not both source and destination as a relation:
showSuggestionToast(
`Added to [[${destinationTitle}]]`,
);Currently, users adopting block suggestions see a confusing "Added relation" message even when no relation is being created.
Suggested change
| showSuggestionToast( | |
| `Added relation between [[${sourceTitle}]] and [[${destinationTitle}]]`, | |
| ); | |
| showSuggestionToast( | |
| `Added to [[${destinationTitle}]]`, | |
| ); | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user adopts a suggestion in Suggestive Mode (Roam), they now receive clear feedback about where the content was added:
Added to [[Page Name]]disableSidebarOpensetting enabled → shows the same toast instead of opening the sidebarFor reified relation adoptions (when Stored Relations are enabled), a toast confirms the relation was created:
Added relation between [[Source]] and [[Destination]].Changes
apps/roam/src/utils/notifySuggestiveModeAdoption.ts(new) — notification logic for block and relation suggestion adoptionapps/roam/src/components/SuggestionsBody.tsx— wiresnotifyBlockSuggestionAdded/notifyRelationSuggestionAddedintohandleCreateBlockTest plan
disableSidebarOpenenabled: adopt a suggestion → toast appears regardless of sidebar state