[ENG-1852] Keep Roam shared node content fresh#1147
Draft
sid597 wants to merge 8 commits into
Draft
Conversation
The cross-app node contract (ENG-1847) carries nodeType = { sourceLocalId, label } and the instance Concept references it via schema_represented_by_local_id, but the fixtures persisted no is_schema:true schema Concept for that id. Add the required schemaConcept (Roam Claim, Obsidian Evidence) carrying stable source identity + label only -- no source_data/format/color/tag, per the contract's "without redefining schema shape".
Roam's existing 5-min sync already persists the schema Concept per contract (convertDgToSupabaseConcepts -> discourseNodeSchemaToLocalConcept; all types on initial sync, edited types incrementally via nodeTypeSince), so no Roam sync code change is needed for F4/F9/F13. Stacked on eng-1847 (PR #1129, unmerged).
…de-type-schema-metadata-for-shared-nodes # Conflicts: # packages/database/package.json # packages/database/src/crossAppNodeContract.ts # packages/database/src/lib/rid.ts
# Conflicts: # apps/roam/src/utils/convertRoamNodeToFullContent.ts # apps/roam/src/utils/syncDgNodesToSupabase.ts # packages/database/package.json # packages/database/src/crossAppNodeContract.ts # packages/database/src/lib/rid.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
sid597
changed the base branch from
main
to
eng-1848-add-roam-full-markdown-content-variant-for-shared-nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:page/edit-timeor title-level:edit/time.fullmarkdown content without running embeddings, while keeping direct/direct_and_description embedding updates on the existing changed-node path.Stack / dependencies
This PR is stacked on #1134 / ENG-1848 because ENG-1852 extends the Roam full-markdown content writer introduced there. Stacking on ENG-1848 keeps that contract work out of this review.
It is still blocked by #1131 / ENG-1849 for schema metadata persistence. Until ENG-1849 lands or is restacked under ENG-1848, this PR can still show the small schema-metadata dependency in its diff.
Validation
pnpm --filter roam check-typespnpm --filter @repo/database check-typespnpm --filter roam lint(0 errors, existing warnings remain)git diff --check HEAD~1..HEAD