Use vault fallback while Datacore initializes - #1258
Open
NathanSkene wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.core.initializedstate before using its query indexReproduction
Datacore exposes its API during plugin loading, but initializes its index asynchronously on
workspace.onLayoutReady. During a first install, reindex, or cache rebuild, Discourse Graph can therefore see a loaded Datacore API whosecore.initializedflag is still false. Queries in that window can return an empty or partial universe even though matching discourse nodes are already available through Obsidian's metadata cache.The previous distribution-repository PR described the index as potentially “empty or stale.” The reproduced case is narrower: Datacore is present but has not finished initialization. This change does not treat an empty result from an initialized index as stale.
Validation
pnpm --filter @discourse-graphs/obsidian test— 5 tests passpnpm --filter @discourse-graphs/obsidian check-typestsx scripts/build.ts)git diff --checkReplaces DiscourseGraphs/discourse-graph-obsidian#9, which targeted the generated distribution repository.