ENG-2083 Add schema selection panel UI for Obsidian export/import - #1262
Open
trangdoan982 wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This was referenced Jul 29, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
trangdoan982
force-pushed
the
eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport
branch
from
July 29, 2026 02:53
1e624f3 to
f8e4b8d
Compare
trangdoan982
force-pushed
the
eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport
branch
from
July 29, 2026 02:58
f8e4b8d to
e9132f3
Compare
trangdoan982
force-pushed
the
eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport
branch
from
July 29, 2026 19:45
e9132f3 to
6eefcca
Compare
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…emplateToNodeTypeNames double-pass - Remove `emptyTemplateText` prop from SchemaSelectionPanel and SchemaSelectionModalBody; hardcode "No template files found." - Remove `beforePanel` and `afterPanel` props from SchemaSelectionModalBody (afterPanel had no callers; beforePanel is now composed as a sibling at the call site) - Collapse templateToNodeTypeNames two-pass sort into a single sorted source array + single map-build pass Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/fe0b8ebcf08e48229a4afdb7a6cc5e43
Summary
Adds the reusable schema selection panel used by both the export and import modals.
SchemaSelectionModalBody.tsx— modal layout with a header slot, scrollable content area, and footer action buttons; consumed by bothExportSpecsModalandImportSpecsModalSchemaSelectionPanel.tsx— four-section checklist (node types, relation types, relation triples, templates) driven byuseSchemaSelection; shows locked/required badges when an item is forced by a selected tripleStack
PR 2 of 5 for FEE-840. Stacks on #1180.
Test plan
pnpm --filter @discourse-graphs/obsidian check-typespasses