[ENG-1450] Update wikilink#807
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
left a comment
There was a problem hiding this comment.
Ok good work in general, one definite small change, and a bigger one MAYBE.
We now have another layer of nesting:
import/<vaultname>/discourseGraphs/<node>.md.
the discourseGraphs folder was not part of the structure before.
I think that was good for users, but I do realize it creates a risk of collision, and it makes path negotiation more complex. Maybe to bring to the group?
|
Re earlier point:
Was brought to group, new approach was accepted. |
93fba8c to
cbb1895
Compare
|
@maparent ready for re-review |
maparent
left a comment
There was a problem hiding this comment.
There's a last Devin comment I'd like you to address:
https://app.devin.ai/review/discoursegraphs/discourse-graph/pull/807#bug-BUG_pr-review-job-926445aef90b47018d94bec75c2b637f_0001
Otherwise LGTM.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…so disguise relative links.
e83bc0f to
592c984
Compare
https://www.loom.com/share/72dcd8692629433f984358bb4e86b2b4