Skip to content

[ENG-1450] Update wikilink#807

Merged
trangdoan982 merged 13 commits into
mainfrom
eng-1450-update-wikilink
Mar 16, 2026
Merged

[ENG-1450] Update wikilink#807
trangdoan982 merged 13 commits into
mainfrom
eng-1450-update-wikilink

Conversation

@trangdoan982

@trangdoan982 trangdoan982 commented Feb 21, 2026

Copy link
Copy Markdown
Member

@linear

linear Bot commented Feb 21, 2026

Copy link
Copy Markdown

@supabase

supabase Bot commented Feb 21, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

graphite-app[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@maparent maparent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good work in general, one definite small change, and a bigger one MAYBE.
We now have another layer of nesting:
import/<vaultname>/discourseGraphs/<node>.md.
the discourseGraphs folder was not part of the structure before.
I think that was good for users, but I do realize it creates a risk of collision, and it makes path negotiation more complex. Maybe to bring to the group?

Comment thread apps/obsidian/src/utils/importNodes.ts
devin-ai-integration[bot]

This comment was marked as resolved.

graphite-app[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

graphite-app[bot]

This comment was marked as resolved.

@maparent

Copy link
Copy Markdown
Collaborator

Re earlier point:

We now have another layer of nesting: import/<vaultname>/discourseGraphs/<node>.md. the discourseGraphs folder was not part of the structure before. I think that was good for users, but I do realize it creates a risk of collision, and it makes path negotiation more complex. Maybe to bring to the group?

Was brought to group, new approach was accepted.

@trangdoan982 trangdoan982 force-pushed the eng-1450-update-wikilink branch from 93fba8c to cbb1895 Compare March 2, 2026 16:52
@trangdoan982

trangdoan982 commented Mar 2, 2026

Copy link
Copy Markdown
Member Author

devin-ai-integration[bot]

This comment was marked as resolved.

@maparent maparent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trangdoan982 trangdoan982 force-pushed the eng-1450-update-wikilink branch from e83bc0f to 592c984 Compare March 16, 2026 15:44
@trangdoan982 trangdoan982 merged commit 1cb8ce1 into main Mar 16, 2026
7 checks passed
@trangdoan982 trangdoan982 deleted the eng-1450-update-wikilink branch March 16, 2026 15:46

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 15 additional findings in Devin Review.

Open in Devin Review

Comment thread apps/obsidian/src/utils/importNodes.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants