ENG-1461 Use full Rid instead of just spaceUri as marker of import by maparent · Pull Request #808 · DiscourseGraphs/discourse-graph

maparent · 2026-02-21T14:55:03Z

https://linear.app/discourse-graphs/issue/ENG-1461/use-full-rid-instead-of-just-spaceuri-as-marker-of-import

This PR migrates imported node frontmatter from using importedFromSpaceUri to using importedFromRid, which contains both the original node's spaceUri and the original sourceLocalId, in the form of a koi-compliant Rid.
(See Rid specs

Previously imported nodes are migrated accordingly.

Also, the sourceRid is added to the schema types, so we have provenance for schemas.

https://www.loom.com/share/b5dc1662b79e4b56a7ff0e3bf74b7039

linear · 2026-02-21T14:55:06Z

ENG-1461 Use full Rid instead of just spaceUri as marker of import

supabase · 2026-02-21T14:55:11Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

trangdoan982

beside the unnecessary migration i think this is good to go

trangdoan982 · 2026-02-23T15:27:59Z

  }
 };

+const migrateImportedFromFrontMatter = async (plugin: DiscourseGraphPlugin) => {


i don't think we need this function. because the first "actual" use case will be from Holehouse which has no initial data. This is only if you care about our testing data being migration but for production I don't think this is necessary.

trangdoan982 · 2026-02-23T15:33:52Z

@@ -0,0 +1,29 @@
+export const spaceUriAndLocalIdToRid = (


nit: maybe here is a good place to document the structure/ link to the RID structure https://github.com/BlockScience/rid-lib

devin-ai-integration

Devin Review found 1 new potential issue.

View 18 additional findings in Devin Review.

devin-ai-integration · 2026-02-23T16:36:51Z

          ...[
            "nodeTypeId",
-            "importedFromSpaceUri",
+            "importedFromRid",


🟡 updateFrontmatterStyles doesn't hide legacy importedFromSpaceUri field

The updateFrontmatterStyles method hides importedFromRid from frontmatter display when showIdsInFrontmatter is false, but does not hide the legacy importedFromSpaceUri field. Before migration completes (or if migration fails for a node), the legacy field will be visible in the frontmatter UI.

Impact

This is a UI inconsistency: the old importedFromSpaceUri field will be visible in the Obsidian properties view for files that haven't been migrated yet, even when the user has configured frontmatter IDs to be hidden.

Suggested change

"importedFromRid",

"importedFromRid",

"importedFromSpaceUri",

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration

Devin Review found 2 new potential issues.

View 16 additional findings in Devin Review.

devin-ai-integration · 2026-02-23T17:14:20Z

      return;
    }
-    const isImported = !!frontmatter.importedFromSpaceUri;
+    const isImported = !!frontmatter.importedFromRid;


🔴 DiscourseContextView isImported check misses legacy importedFromSpaceUri, showing Publish button for imported nodes

Both isImported checks in DiscourseContextView.tsx (lines 40 and 128) only check for importedFromRid, not the legacy importedFromSpaceUri. For previously imported files that haven't been migrated, isImported will be false.

Root Cause and Impact

At line 40:

const isImported = !!frontmatter.importedFromRid;

And at line 128:

const isImported = !!frontmatter.importedFromRid;

For legacy imported files, this means:

The "Refresh" button will not be shown (since isImported is false)

The "Publish" button may be shown instead (since canPublish checks !isImported)

Source dates (created/modified in source) won't be displayed

Publishing an imported file could cause unintended data changes in the user's lab space.

Suggested change

const isImported = !!frontmatter.importedFromRid;

const isImported = !!frontmatter.importedFromRid || !!frontmatter.importedFromSpaceUri;

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-02-23T17:14:21Z

    const cache = plugin.app.metadataCache.getFileCache(file);
    const frontmatter = cache?.frontmatter;
-    if (frontmatter?.importedFromSpaceUri && frontmatter?.nodeInstanceId) {
+    if (frontmatter?.importedFromRid && frontmatter?.nodeInstanceId) {


🔴 refreshAllImportedFiles skips legacy imported files that only have importedFromSpaceUri

The refreshAllImportedFiles function at importNodes.ts:1431 only finds files with importedFromRid in their frontmatter, silently skipping any legacy imported files that still have importedFromSpaceUri.

Root Cause and Impact

At line 1431:

if (frontmatter?.importedFromRid && frontmatter?.nodeInstanceId) { importedFiles.push(file); }

Legacy files with only importedFromSpaceUri will be excluded. When the user triggers "refresh all imported files", these files will simply be skipped with no error or indication, leaving them stale.

Impact: Users who upgrade to this version and try to refresh all imported files will find that previously imported files are silently skipped. Those files will never get refreshed unless manually re-imported.

Suggested change

if (frontmatter?.importedFromRid && frontmatter?.nodeInstanceId) {

if ((frontmatter?.importedFromRid || frontmatter?.importedFromSpaceUri) && frontmatter?.nodeInstanceId) {

Was this helpful? React with 👍 or 👎 to provide feedback.

This comment was marked as resolved.

Sign in to view

maparent requested a review from trangdoan982 February 21, 2026 18:20

trangdoan982 approved these changes Feb 23, 2026

View reviewed changes

maparent added 11 commits February 23, 2026 11:28

eng-1461 use Rid instead of just spaceUri as mark of import

45be119

devin corrections

0342cea

add importedFromRid to imported node schemata

5ec4d66

repair types

0595d31

Actually keep obsidian space id as-is; smarter parse of rid

5bf85fd

corrections

7a87908

corrections

5ad710e

move migrateImportedFromFrontMatter to sync

01c5c1a

rid regex corrections

21ed1a5

nit: name in comment

6cb087a

Do not subtype schemas

5699c31

maparent force-pushed the eng-1461-use-full-rid-instead-of-just-spaceuri-as-marker-of-import branch from 6983308 to 5699c31 Compare February 23, 2026 16:30

devin-ai-integration Bot reviewed Feb 23, 2026

View reviewed changes

remove migration

7045869

devin-ai-integration Bot reviewed Feb 23, 2026

View reviewed changes

documentation

8832d61

maparent merged commit 263be02 into main Feb 23, 2026
8 checks passed

maparent deleted the eng-1461-use-full-rid-instead-of-just-spaceuri-as-marker-of-import branch February 23, 2026 18:59

	const isImported = !!frontmatter.importedFromRid;
	const isImported = !!frontmatter.importedFromRid \|\| !!frontmatter.importedFromSpaceUri;

	if (frontmatter?.importedFromRid && frontmatter?.nodeInstanceId) {
	if ((frontmatter?.importedFromRid \|\| frontmatter?.importedFromSpaceUri) && frontmatter?.nodeInstanceId) {

Uh oh!

Conversation

maparent commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear Bot commented Feb 21, 2026

Uh oh!

supabase Bot commented Feb 21, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

trangdoan982 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maparent commented Feb 21, 2026 •

edited

Loading

trangdoan982 left a comment •

edited

Loading