Skip to content

Commit e390568

Browse files
committed
change functions to force all data arguments to be treated as data frames
1 parent 684b826 commit e390568

19 files changed

Lines changed: 30 additions & 20 deletions

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# markeR 0.9.X (?? ??, ????)
2+
23
* Added `VisualiseIndividualGenes()` wrapper to unify individual gene visualisation functions (`ExpressionHeatmap`, `ROCandAUCplot`, etc.) under a single, user-friendly interface.
4+
* Ensured all data arguments are data frames for consistency across functions.
35

46
# markeR 0.9.4 (09 Jul, 2025)
57

R/CalculateScores.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
#'
9393
#' @export
9494
CalculateScores <- function(data, metadata, gene_sets, method = c("ssGSEA", "logmedian","ranking", "all")) {
95-
95+
data <- as.data.frame(data) # Ensure data is a data frame
9696
method <- match.arg(method) # Validate method input
9797

9898
if (!is.data.frame(data)) stop("Error: data must be a data-frame")

R/CalculateScores_Ranking.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
#'}
4646
#' @keywords internal
4747
CalculateScores_Ranking <- function(data, metadata = NULL, gene_sets) {
48-
48+
data <- as.data.frame(data) # Ensure data is a data frame
4949
ResultsList <- list()
5050

5151
if (!is.data.frame(data)) stop("Error: data must be a data frame")
@@ -147,7 +147,7 @@ CalculateScores_Ranking <- function(data, metadata = NULL, gene_sets) {
147147
#'}
148148
#' @keywords internal
149149
getRanking <- function(data, sample, geneset) {
150-
150+
data <- as.data.frame(data) # Ensure data is a data frame
151151
expressiongene <- data[, sample] # Isolate one sample and get the expression of all genes
152152
names(expressiongene) <- row.names(data) # Name vector
153153
expressiongene <- expressiongene[order(expressiongene, decreasing = FALSE)] # Order from least to most expressed

R/CalculateScores_logmedian.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
#' }
3636
#' @keywords internal
3737
CalculateScores_logmedian <- function(data, metadata = NULL, gene_sets) {
38+
data <- as.data.frame(data) # Ensure data is a data frame
3839
ResultsList <- list()
3940

4041
for (sig in names(gene_sets)) {
@@ -83,6 +84,7 @@ CalculateScores_logmedian <- function(data, metadata = NULL, gene_sets) {
8384
#' @return A named vector with log-median-centered scores per sample.
8485
#' @keywords internal
8586
calculateScore_logmedian_bidirectional <- function(data, signature) {
87+
data <- as.data.frame(data) # Ensure data is a data frame
8688
signature[, 2] <- as.numeric(signature[, 2])
8789

8890
if (!all(unique(signature[, 2]) %in% c(-1, 1))) {
@@ -122,6 +124,7 @@ calculateScore_logmedian_bidirectional <- function(data, signature) {
122124
#' @return A named vector with log-median-centered scores per sample.
123125
#' @keywords internal
124126
calculateScore_logmedian_unidirectional <- function(data, signature) {
127+
data <- as.data.frame(data) # Ensure data is a data frame
125128
if (is.data.frame(signature)) signature <- as.vector(signature[, 1])
126129

127130
data_subset <- na.omit(subset(log2(data + 1), row.names(data) %in% signature))

R/CalculateScores_ssGSEA.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#' @keywords internal
2222

2323
CalculateScores_ssGSEA <- function(data, metadata = NULL, gene_sets) {
24+
data <- as.data.frame(data) # Ensure data is a data frame
2425
ResultsList <- list()
2526

2627
for (sig in names(gene_sets)) {
@@ -89,6 +90,7 @@ CalculateScores_ssGSEA <- function(data, metadata = NULL, gene_sets) {
8990
#'}
9091
#' @keywords internal
9192
CalculateScores_ssGSEA_unidirectional <- function(data, signature) {
93+
data <- as.data.frame(data) # Ensure data is a data frame
9294
ResultsList <- list()
9395

9496
siglist <- list(signature)
@@ -150,6 +152,7 @@ CalculateScores_ssGSEA_unidirectional <- function(data, signature) {
150152
#'}
151153
#' @keywords internal
152154
CalculateScores_ssGSEA_bidirectional <- function(data, signature) {
155+
data <- as.data.frame(data) # Ensure data is a data frame
153156
ResultsList <- list()
154157

155158
mtx <- log2(data)

R/CohenD_IndividualGenes.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ CohenD_IndividualGenes <- function(data, metadata,
9797
title = NULL,
9898
titlesize = 16,
9999
params = list()) {
100-
100+
data <- as.data.frame(data) # Ensure data is a data frame
101101
# If genes are not specified, use all available genes
102102
if (is.null(genes)) {
103103
genes <- rownames(data)

R/CorrelationHeatmap.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ CorrelationHeatmap <- function(data, metadata = NULL, genes, separate.by = NULL,
116116
show_row_names=TRUE,
117117
show_column_names=TRUE) {
118118

119-
119+
data <- as.data.frame(data) # Ensure data is a data frame
120120
# Choose legend position: "side" (vertical) or "top" (horizontal)
121121
legend_position <- match.arg(legend_position)
122122
method <- match.arg(method)

R/ExpressionHeatmap.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ ExpressionHeatmap <- function(data, metadata = NULL, genes, annotate.by = NULL,
8888
legend_position = c("top", "right", "bottom"),
8989
show_row_names=TRUE,
9090
show_column_names=FALSE) {
91-
91+
data <- as.data.frame(data) # Ensure data is a data frame
9292
# Ensure the scale_position and legend_position arguments are matched correctly
9393
scale_position <- match.arg(scale_position)
9494
legend_position <- match.arg(legend_position)

R/FPR_Simulation.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
FPR_Simulation <- function(data, metadata, original_signatures, Variable, gene_list = NULL, number_of_sims=10, title=NULL,
9292
widthTitle = 30, titlesize = 12, pointSize = 2,
9393
labsize = 10,mode = c( "none","simple","medium","extensive"), ColorValues=NULL, ncol=NULL, nrow=NULL) {
94-
94+
data <- as.data.frame(data) # Ensure data is a data frame
9595
if (is.null(gene_list)) gene_list <- row.names(data)
9696

9797
methods <- c("ssGSEA", "logmedian", "ranking")

R/GSEA_VariableAssociation.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
#'
8383
#' @keywords internal
8484
GSEA_VariableAssociation <- function(data, metadata, cols, stat=NULL, mode=c("simple","medium","extensive"), gene_set,nonsignif_color = "grey", signif_color = "red", saturation_value=NULL,sig_threshold = 0.05, widthlabels=18, labsize=10, titlesize=14, pointSize=5, ignore_NAs = FALSE, printplt =TRUE) {
85+
data <- as.data.frame(data) # Ensure data is a data frame
8586
mode <- match.arg(mode)
8687
metadata <- metadata[, cols %in% colnames(metadata), drop = FALSE]
8788

0 commit comments

Comments
 (0)