fix: escape headers and unordered lists in markdown utils#1058
Open
onerandomusername wants to merge 7 commits into
Open
fix: escape headers and unordered lists in markdown utils#1058onerandomusername wants to merge 7 commits into
onerandomusername wants to merge 7 commits into
Conversation
shiftinv
requested changes
Jun 20, 2023
shiftinv
left a comment
Member
There was a problem hiding this comment.
This replaces # and - anywhere in a string, not only at the start of a line
Seems like something that could use a bunch of testing, so moving it to the next version might make sense here.
Member
Author
Sigh, that's fair. Possibly can be part of a bugfix release, like 2.9.1 |
onerandomusername
force-pushed
the
expanded-markdown
branch
from
June 24, 2023 10:10
242e5a5 to
cb0085e
Compare
Member
Author
|
Due to more quirks with the client this entire implementation is wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expanded markdown support in remove markdown and escape markdown methods. This does not currently support ordered lists, unfortunately.
Checklist
pdm lintpdm pyright