Skip to content

fix(typing): allow ForwardedMessage in components_from_message and similar methods#1566

Merged
shiftinv merged 3 commits into
masterfrom
fix/forwardedmessage-components
Jul 15, 2026
Merged

fix(typing): allow ForwardedMessage in components_from_message and similar methods#1566
shiftinv merged 3 commits into
masterfrom
fix/forwardedmessage-components

Conversation

@shiftinv

@shiftinv shiftinv commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

Adds support for ForwardedMessage to ActionRow.rows_from_message, components_from_message, and View.from_message. This already worked perfectly fine at runtime, but showed a type-checker error due to an overly restrictive param type.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.13 milestone Jul 9, 2026
@shiftinv shiftinv added t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix labels Jul 9, 2026
@github-project-automation github-project-automation Bot moved this to Todo in disnake Jul 9, 2026
@shiftinv shiftinv added this to disnake Jul 9, 2026
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 disnake | 🛠️ Build #33518301 | 📁 Comparing 8edd9c1 against latest (863033f)

  🔍 Preview build  

47 files changed · ± 47 modified

± Modified

@shiftinv
shiftinv merged commit 16641e9 into master Jul 15, 2026
33 of 34 checks passed
@shiftinv
shiftinv deleted the fix/forwardedmessage-components branch July 15, 2026 12:27
@github-project-automation github-project-automation Bot moved this from Todo to Done in disnake Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant