Commit 40d64e0
fix(recipes): remove deprecated fully_shard() kwargs (NVIDIA-BioNeMo#1585)
## Summary
Remove deprecated `fully_shard()` keyword arguments that were removed in
a recent megatron-core update.
### Changes
- **vit/train.py**: Remove `grad_reduce_in_fp32` and
`preserve_fp32_weights` from `fully_shard()` call
- **vit/config/defaults.yaml + vit_base_patch16_224.yaml**: Remove
orphaned config keys
- **esm2_native_te/hydra_config/defaults.yaml**: Remove
`check_for_nan_in_grad`, `grad_reduce_in_fp32`, `preserve_fp32_weights`
- **geneformer_native_te_mfsdp_fp8/hydra_config/defaults.yaml**: Same
### Root Cause
The installed megatron-core in CI has updated `fully_shard()` API,
removing these parameters:
- `grad_reduce_in_fp32`
- `preserve_fp32_weights`
- `check_for_nan_in_grad`
These were simple removals — no replacement mechanism needed for the
affected recipes.
Fixes NVIDIA-BioNeMo#1584
(partially — the `nvidia-resiliency-ext` version mismatch is a container
image issue requiring an image rebuild)
### Testing
- Pre-commit passes on all changed files
- Import verification confirms `fully_shard` loads without the removed
kwargs
Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
Co-authored-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
Co-authored-by: Peter St. John <pstjohn@nvidia.com>1 parent 85a8dcc commit 40d64e0
5 files changed
Lines changed: 0 additions & 14 deletions
File tree
- bionemo-recipes/recipes
- esm2_native_te/hydra_config
- geneformer_native_te_mfsdp_fp8/hydra_config
- vit
- config
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | 37 | | |
41 | 38 | | |
42 | 39 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 34 | | |
38 | 35 | | |
39 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | 58 | | |
61 | 59 | | |
62 | 60 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | 56 | | |
59 | 57 | | |
60 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | 98 | | |
103 | 99 | | |
104 | 100 | | |
| |||
0 commit comments