Skip to content

Commit 11b1767

Browse files
committed
Revert "fix: a JS symbol is exported on dcp/utils module scope, which is an unsupported type in PythonMonkey"
This reverts commit ec8811e.
1 parent c1c4e41 commit 11b1767

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

dcp/initialization.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,8 @@ def init_dcp_module(py_parent, js_module, js_name):
6868
# add the new module as a submodule of the root module
6969
setattr(py_parent, underscore_name, module)
7070

71-
if hasattr(js_module, 'keys'):
72-
for prop_name in js_module.keys():
73-
try:
74-
prop_ref = js_module[prop_name]
75-
except TypeError:
76-
# Unsupported types may also be exported on the js_module scope, we can ignore them
77-
# "TypeError: symbol type is not handled by PythonMonkey yet"
78-
continue
71+
if hasattr(js_module, 'items'):
72+
for prop_name, prop_ref in js_module.items():
7973
# modify props if required
8074
# TODO: should this be a dict of prop_name and list of modules with overridden ref?
8175
# TODO: maybe stuff like this should be specified in one places instead of spat throughout the codebase

0 commit comments

Comments
 (0)