Add setting to pass proxies to requests#212
Merged
claudep merged 7 commits intoSep 28, 2025
Merged
Conversation
Contributor
ben-beauhurst
commented
Sep 15, 2025
ben-beauhurst
commented
- Added a setting LINKCHECK_PROXIES so that proxies can be passed to the requests
- Added another setting LINKCHECK_TRUST_PROXY_SSL to give the option to turn off SSL verification
- Added a test
claudep
reviewed
Sep 15, 2025
| 'linkcheck.models.PROXIES', | ||
| {'http': 'http://proxy.example.com:8080'}, | ||
| ) | ||
| @patch('requests.head') |
Contributor
There was a problem hiding this comment.
Did you try using @requests_mock.Mocker(), as other tests in this file are using?
Contributor
Author
There was a problem hiding this comment.
I've updated it to use requests_mock like the other tests
claudep
requested changes
Sep 15, 2025
Contributor
claudep
left a comment
claudep
left a comment
There was a problem hiding this comment.
The new settings should be documented in the README.
…ng it in line with the other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.