fix(clihttp): log errors (#212)

* fix: add clihttp Providers

* fix: add clihttp Providers

* fix: add clihttp Providers

* fix: add clihttp Providers

* fix(logging): inconsistency between go kit Logger and spanLogger

Only log.Valuer passed via log.With are treated as dynamic argument in go kit log. The change makes spanLogger consistent with go kit.

* fix(clihttp): correctly logs error

Author: Reasno

clihttp/client.go

@@ -88,6 +88,8 @@ func (c *Client) Do(req *http.Request) (*http.Response, error) {
 	c.tracer.Inject(clientSpan.Context(), opentracing.HTTPHeaders, opentracing.HTTPHeadersCarrier(req.Header))
 	response, err := c.underlying.Do(req)
 	if err != nil {
+		ext.Error.Set(clientSpan, true)
+		clientSpan.LogFields(log.String("event", "error"), log.String("message", err.Error()))
 		return response, err
 	}
 

clihttp/client_test.go

@@ -38,14 +38,23 @@ func TestClient_Do(t *testing.T) {
 			func() *http.Request { r, _ := http.NewRequest("GET", "https://example.com/", nil); return r }(),
 			[]Option{WithResponseLogThreshold(1)},
 		},
+		{
+			"error",
+			func() *http.Request { r, _ := http.NewRequest("GET", "https://non-exist-domain.com/", nil); return r }(),
+			[]Option{},
+		},
 	}
 	for _, c := range cases {
 		c := c
 		t.Run(c.name, func(t *testing.T) {
 			t.Parallel()
 			tracer := mocktracer.New()
 			client := NewClient(tracer, c.Option...)
-			resp, _ := client.Do(c.request)
+			resp, err := client.Do(c.request)
+			if err != nil {
+				assert.True(t, tracer.FinishedSpans()[0].Tags()["error"].(bool))
+				return
+			}
 			defer resp.Body.Close()
 			assert.NotEmpty(t, tracer.FinishedSpans())
 			byt, _ := ioutil.ReadAll(resp.Body)