Fix N+1 query in course sitemap generation#360
Merged
Conversation
Replace inefficient per-course document query with database aggregation
using Max() annotation. This reduces sitemap generation from N+1 queries
to just 1 query, where N is the number of courses.
Before:
- items() prefetched document_set for each course
- lastmod() called .order_by().first() for each course (N queries)
- For 1000 courses: 1001 queries
After:
- items() annotates with Max('document__created')
- lastmod() returns annotated field
- For 1000 courses: 1 query
This fix prevents database overload during sitemap generation and
significantly improves response time for sitemap endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.