feat: add filters and improved table to team requests (#4)

* feat: add filters and improved table to `team requests`

  - Add -n flag to limit results (default: 10)
  - Add --status flag (repeatable) to filter by status
  - Add --all flag to bypass status filtering
  - Dynamic column widths based on content length
  - Status legend printed below the table
  - Change ended icon to ☑️

Signed-off-by: Nicolò Ciraci <nicolo.ciraci@docplanner.com>

* fix: default to all statuses

Signed-off-by: Nicolò Ciraci <nicolo.ciraci@docplanner.com>

---------

Signed-off-by: Nicolò Ciraci <nicolo.ciraci@docplanner.com>

Author: CiraciNicolo

team_cli/cli.py

@@ -464,7 +464,17 @@ def cmd_requests(args):
     with with_spinner("Fetching requests..."):
         reqs = get_requests_by_email(user["email"], tokens)
 
-    print(format_request_table(reqs))
+    if args.status:
+        statuses = {s.lower() for s in args.status}
+        reqs = [r for r in reqs if r.get("status", "").lower() in statuses]
+
+    limit = args.n
+    truncated = len(reqs) > limit
+    reqs = reqs[:limit]
+
+    print(format_request_table(reqs, show_legend=True))
+    if truncated:
+        print(f"\n(showing {limit} most recent — use -n to change limit)")
 
 
 def cmd_status(args):
@@ -843,8 +853,13 @@ def build_parser() -> argparse.ArgumentParser:
                             help="Max seconds to wait (default: 600)")
 
     # requests
-    sub.add_parser("requests", help="List my requests",
-        description="Show all your elevation requests with status, account, role, and timestamps.")
+    requests_parser = sub.add_parser("requests", help="List my requests",
+        description="Show your elevation requests with status, account, role, and timestamps.")
+    requests_parser.add_argument("-n", type=int, default=10, metavar="N",
+        help="Max number of requests to show (default: 10)")
+    requests_parser.add_argument("--status", action="append", metavar="STATUS",
+        help="Filter by status; can be repeated. "
+             "Allowed: pending, approved, rejected, revoked, cancelled, in progress, scheduled, ended, expired")
 
     # status
     status_parser = sub.add_parser("status", help="Check request status",

team_cli/interactive.py

@@ -182,38 +182,72 @@ def _prompt_justification_and_ticket_basic(account_name: str, prev_j: str | None
     return justification, ticket
 
 
-def format_request_table(requests_list: list[dict]) -> str:
-    """Format requests as a readable table."""
+_STATUS_LEGEND = [
+    ("⏳", "pending",     "Waiting for approver action"),
+    ("📅", "scheduled",   "Approved, session not yet started"),
+    ("⏩", "in progress", "Session currently active"),
+    ("✅", "approved",    "Approved (session may have started)"),
+    ("☑️", "ended",       "Session completed normally"),
+    ("❌", "rejected",    "Rejected by approver"),
+    ("🔄", "revoked",     "Revoked after approval"),
+    ("🚫", "cancelled",   "Cancelled by requester"),
+    ("💤", "expired",     "Expired without action"),
+]
+
+_STATUS_ICON = {s: icon for icon, s, _ in _STATUS_LEGEND}
+
+
+def format_request_table(requests_list: list[dict], show_legend: bool = False) -> str:
+    """Format requests as a readable table with dynamic column widths."""
     if not requests_list:
         return "No requests found."
 
-    # Status icons
-    status_icon = {
-        "pending": "⏳",
-        "approved": "✅",
-        "rejected": "❌",
-        "revoked": "🔄",
-        "cancelled": "🚫",
-        "in progress": "⏩",
-        "scheduled": "📅",
-        "ended": "⏹",
-        "expired": "💤",
-    }
-
-    lines = []
-    lines.append(f"{'ID':<38} {'Account':<22} {'Role':<30} {'Duration':>4}h  {'Status':<12} {'Created'}")
-    lines.append("─" * 130)
-
+    rows = []
     for r in sorted(requests_list, key=lambda x: x.get("createdAt", ""), reverse=True):
-        rid = r.get("id", "")[:36]
-        account = r.get("accountName", "")[:20]
-        role = r.get("role", "")[:28]
-        duration = r.get("duration", "")
         status = r.get("status", "unknown")
-        icon = status_icon.get(status.lower(), "?")
-        created = r.get("createdAt", "")[:19]
-
-        lines.append(f"{rid:<38} {account:<22} {role:<30} {str(duration):>4}h  {icon} {status:<10} {created}")
+        rows.append({
+            "id":       r.get("id", "")[:36],
+            "account":  r.get("accountName", ""),
+            "role":     r.get("role", ""),
+            "duration": str(r.get("duration", "")),
+            "status":   status,
+            "icon":     _STATUS_ICON.get(status.lower(), "?"),
+            "created":  r.get("createdAt", "")[:19],
+        })
+
+    w_id       = max(len("ID"),       max(len(r["id"])       for r in rows))
+    w_account  = max(len("Account"),  max(len(r["account"])  for r in rows))
+    w_role     = max(len("Role"),     max(len(r["role"])     for r in rows))
+    w_duration = max(len("Dur"),      max(len(r["duration"]) for r in rows))
+    w_status   = max(len("Status"),   max(len(r["status"])   for r in rows))
+    w_created  = len("Created")  # always 19 chars
+
+    header = (
+        f"{'ID':<{w_id}}  "
+        f"{'Account':<{w_account}}  "
+        f"{'Role':<{w_role}}  "
+        f"{'Dur':>{w_duration}}h  "
+        f"   {'Status':<{w_status}}  "
+        f"{'Created'}"
+    )
+    total = len(header)
+
+    lines = [header, "─" * total]
+    for r in rows:
+        lines.append(
+            f"{r['id']:<{w_id}}  "
+            f"{r['account']:<{w_account}}  "
+            f"{r['role']:<{w_role}}  "
+            f"{r['duration']:>{w_duration}}h  "
+            f"{r['icon']} {r['status']:<{w_status}}  "
+            f"{r['created']}"
+        )
+
+    if show_legend:
+        lines.append("")
+        lines.append("Status legend:")
+        for icon, name, description in _STATUS_LEGEND:
+            lines.append(f"  {icon} {name:<12}  {description}")
 
     return "\n".join(lines)